zos: set compiler flags based on compiler and node versions

gabylb · joeferner · commit 2e56c9174900 · 2021-07-08T22:24:02.000Z
This is to workaround previous (to v14) versions of node
and a compiler bug affected by those versions, as follows:

- v8 (ships with D190508), requires -U_VARARG_EXT_ and no-opt
- v12 (ships with D191122), requires no-opt
- v14 (ships with D191122), no workaround needed.
diff --git a/binding.gyp b/binding.gyp
@@ -24,6 +24,9 @@
       ['OS=="linux" or OS=="mac" or OS=="freebsd" or OS=="openbsd" or OS=="solaris"', {
         'javalibdir%': "<!(./find_java_libdir.sh <(target_arch) <(OS))"
       }],
+      ['OS=="zos"', {
+        'nodever%': '<!(node -e "console.log(process.versions.node)" | cut -d"." -f1)',
+      }],
     ]
   },
   'targets': [
@@ -101,9 +104,22 @@
             ]
           }
         ],
-        ["OS=='zos'", {
-          "cflags!": [ "-O2", "-O3" ]
-        }],
+        ['OS=="zos"',
+          {
+            'conditions': [
+              ['nodever<14',
+                {
+                  'cflags!': [ "-O2", "-O3" ]
+                }
+              ],
+              ['nodever<12',
+                {
+                  'cflags': [ "-U_VARARG_EXT_" ],
+                }
+              ]
+            ]
+          }
+        ],
         ['OS=="mac"',
           {
             'xcode_settings': {
