From f0017a2c733a4f924ac027f44e8d6eb7248143c7 Mon Sep 17 00:00:00 2001 From: NoelStephensUnity Date: Wed, 11 Dec 2024 22:28:23 -0600 Subject: [PATCH] fix Removing timesouts from our integration tests: - TestSendingWithGroupOverride - TestSendingWithGroupNotOverride - WhenManyObjectsAreSpawnedAtOnce_AllAreReceived( --- .../NetworkObject/NetworkObjectSpawnManyObjectsTests.cs | 2 -- .../Tests/Runtime/UniversalRpcTests.cs | 4 ---- 2 files changed, 6 deletions(-) diff --git a/com.unity.netcode.gameobjects/Tests/Runtime/NetworkObject/NetworkObjectSpawnManyObjectsTests.cs b/com.unity.netcode.gameobjects/Tests/Runtime/NetworkObject/NetworkObjectSpawnManyObjectsTests.cs index 8f35c970c0..1041ee2931 100644 --- a/com.unity.netcode.gameobjects/Tests/Runtime/NetworkObject/NetworkObjectSpawnManyObjectsTests.cs +++ b/com.unity.netcode.gameobjects/Tests/Runtime/NetworkObject/NetworkObjectSpawnManyObjectsTests.cs @@ -47,8 +47,6 @@ protected override void OnServerAndClientsCreated() } [UnityTest] - // When this test fails it does so without an exception and will wait the default ~6 minutes - [Timeout(10000)] public IEnumerator WhenManyObjectsAreSpawnedAtOnce_AllAreReceived() { for (int x = 0; x < k_SpawnedObjects; x++) diff --git a/com.unity.netcode.gameobjects/Tests/Runtime/UniversalRpcTests.cs b/com.unity.netcode.gameobjects/Tests/Runtime/UniversalRpcTests.cs index e157a3a212..fd307f5a54 100644 --- a/com.unity.netcode.gameobjects/Tests/Runtime/UniversalRpcTests.cs +++ b/com.unity.netcode.gameobjects/Tests/Runtime/UniversalRpcTests.cs @@ -1285,8 +1285,6 @@ public enum AllocationType List } - // Extending timeout since the added yield return causes this test to commonly timeout - [Timeout(600000)] [UnityTest] public IEnumerator TestSendingWithGroupOverride() { @@ -1386,8 +1384,6 @@ public enum AllocationType List } - // Extending timeout since the added yield return causes this test to commonly timeout - [Timeout(600000)] [UnityTest] public IEnumerator TestSendingWithGroupNotOverride() {