Fixed inconsistent scoping of top-level variable declarations#795
Merged
Conversation
ark120202
reviewed
Jan 9, 2020
ark120202
reviewed
Jan 10, 2020
ark120202
reviewed
Jan 12, 2020
| const value1 = obj.value1; | ||
| const { value2 } = obj; | ||
|
|
||
| let noValueLet; |
Contributor
There was a problem hiding this comment.
I wonder if it would be better to transform it to a nil assignment instead of just dropping it?
Member
Author
There was a problem hiding this comment.
Maybe we should decide and do this in another PR
ark120202
reviewed
Jan 14, 2020
ark120202
approved these changes
Jan 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have the convention of treating files without imports or exports as 'global' scripts where all top-level variables are considered global.
Variable declarations however did not adhere to this convention, that has been corrected.
Fixes #720, closes #790