Implement Number.prototype.toString(radix)#752
Merged
Perryvw merged 4 commits intoNov 26, 2019
Conversation
321aaf0 to
32192c4
Compare
Perryvw
reviewed
Nov 25, 2019
| const toStringRadixes = [undefined, 10, 2, 8, 9, 16, 17, 36, 36.9]; | ||
| const toStringValues = [...numberCases, 1024, 1.2, NaN]; | ||
| // TODO: flatMap | ||
| const toStringPairs = toStringValues.reduce<Array<readonly [number, number | undefined]>>( |
Member
There was a problem hiding this comment.
This is very hard to read, maybe we could make some helper function combinations or testCombinations. Also do we really need to check NaN for every radix value? Might be nicer as a separate test.
| return this.toString(); | ||
| } | ||
|
|
||
| radix = Math.floor(radix); |
Member
There was a problem hiding this comment.
Did you use some kind of reference for this implementation? If so, could you add a comment with a link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #723.