Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: CodeYourFuture/JavaScript-Core-1-Coursework-Week1
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: TomRafferty/JavaScript-Core-1-Coursework-Week1
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 15 commits
  • 24 files changed
  • 1 contributor

Commits on Aug 8, 2021

  1. Configuration menu
    Copy the full SHA
    910ee59 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9f02287 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2021

  1. Configuration menu
    Copy the full SHA
    5aa78fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    415901d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c075663 View commit details
    Browse the repository at this point in the history
  4. I believe I fixed the syntax errors

    however when I run the tests in the terminal it says there is 1 syntax issue and I can't figure out what it is.
    TomRafferty committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    1602a08 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b09e0db View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0dff206 View commit details
    Browse the repository at this point in the history
  7. regular commit fixed 3-function-output

    had an issue where I accidentally removed a '}' but it all should work fine now.
    TomRafferty committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    a6085b7 View commit details
    Browse the repository at this point in the history
  8. regular commit having issues with 4-tax.js

    my calculator seems to work with the first couple of tests but then it starts returning random results
    TomRafferty committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    1272aa9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    bc7c376 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. completed extra currency conversion

    The test in this one don't work, I manually checked the expected answers with console.log() and my code works just fine. I tried changing the path of the test as it looks incorrect but I still can't get them to run.
    TomRafferty committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    1a16f2b View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. finished extra 2-piping

    I also uncommented out the tests - though I'm still getting errors when I run them (in the extra 1-currency-conversion)
    TomRafferty committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    fb4f9fd View commit details
    Browse the repository at this point in the history
  2. sort of finished the extra 3-magic-8-ball

    I couldn't make sense of the instructions so I just made a magic 8 ball generator. sorry if this is wrong.
    TomRafferty committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    b4d039d View commit details
    Browse the repository at this point in the history
  3. added a little readability

    yes that one space made a difference!
    TomRafferty committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    bae902f View commit details
    Browse the repository at this point in the history
Loading