Skip to content

BUILD-10993 Evaluate warp-custom-docker-m runner#6907

Draft
mikolaj-matuszny-ext-sonarsource wants to merge 4 commits into
masterfrom
BUILD-10993-evaluate-warp-custom-docker-m
Draft

BUILD-10993 Evaluate warp-custom-docker-m runner#6907
mikolaj-matuszny-ext-sonarsource wants to merge 4 commits into
masterfrom
BUILD-10993-evaluate-warp-custom-docker-m

Conversation

@mikolaj-matuszny-ext-sonarsource
Copy link
Copy Markdown
Contributor

Summary

  • Evaluate warp-custom-docker-m runner as replacement for sonar-m-docker on Alpine Docker QA jobs
  • Reverted workarounds from the original migration to test out-of-the-box compatibility:
    • Removed config-npm action (restored vault-based npm config for all OSes)
    • Restored sudo mv node disabling (instead of function override)
    • Reverted memory.ts / memory.test.ts docker memory detection changes

Changed jobs

Job Old runner New runner
QA without Node on Alpine sonar-m-docker warp-custom-docker-m
Fast QA without Node on Alpine sonar-m-docker warp-custom-docker-m

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented Apr 24, 2026

BUILD-10993

@sonar-review-alpha
Copy link
Copy Markdown
Contributor

sonar-review-alpha Bot commented Apr 24, 2026

Summary

This PR tests whether warp-custom-docker-m can replace sonar-m-docker as the runner for Alpine Docker QA jobs by removing workarounds from the original migration. Two Alpine jobs (plugin_qa_without_node_alpine and plugin_qa_fast_without_node_alpine) switch runners and their execution conditions broaden to run on all PR types (not just scheduled runs). The PR also simplifies npm configuration to use vault secrets consistently across all platforms instead of platform-specific logic.

What reviewers should know

Key changes to verify:

  1. Job runner migration: Two Alpine jobs move from sonar-m-dockerwarp-custom-docker-m. Confirm this new runner is configured and available.

  2. Job condition expansion: if: github.event_name == 'schedule'if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false — this significantly broadens execution to include PRs from non-fork repos. Verify this is intentional and won't cause unintended job runs or cost increases.

  3. npm config consolidation: The OS-specific logic for npm setup (config-npm action + Windows-only vault access) is removed. Now all platforms use vault-based npm config. Verify this works on Alpine/Linux without the removed action.

  4. Test file import reordering (memory.test.ts): Source imports moved before test framework imports. This is a style change but confirm the test suite still passes — the PR description mentions reverting memory detection changes, so test execution is worth validating.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

sonar-review-alpha[bot]

This comment was marked as resolved.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Ruling Report

No changes to ruling expected issues in this PR

sonar-review-alpha[bot]

This comment was marked as outdated.

sonar-review-alpha[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

🗣️ Give feedback

@sonarqube-next
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@zglicz zglicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

name: QA without Node on Alpine SQ:LATEST_RELEASE
needs: [setup, get_build_number, build]
if: github.event_name == 'schedule'
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to revert before merging

name: Fast QA without Node on Alpine SQ:LATEST_RELEASE
needs: [setup, get_build_number, build]
if: github.event_name == 'schedule'
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource marked this pull request as draft April 27, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants