Skip to content

Add Squeak6 (current trunk)#58

Merged
jbrichau merged 5 commits into
SeasideSt:masterfrom
krono:add-squeak6-to-baseline
Nov 18, 2017
Merged

Add Squeak6 (current trunk)#58
jbrichau merged 5 commits into
SeasideSt:masterfrom
krono:add-squeak6-to-baseline

Conversation

@krono

@krono krono commented Nov 8, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@krono

krono commented Nov 8, 2017

Copy link
Copy Markdown
Contributor Author

accompanying Configuration that reditects 6 to here is attached (rename zip -> mcz)
ConfigurationOfGrease-topa.349.zip

@krono

krono commented Nov 9, 2017

Copy link
Copy Markdown
Contributor Author

It turns out that those tests only fail on linux but pass on macOS.

I added that in #59

@jbrichau

jbrichau commented Nov 9, 2017

Copy link
Copy Markdown
Member

Hi @krono,

Since issue #14, we have adopted the strategy to create separate packages per platform version. If we load the same packages in different platform versions, there is more work to support and understand where somethings needs to be fixed to deal with platform differences than fixing a bug across all supported platforms.

So, if we want to add Squeak 6, the best thing to do is to add a separate package for it. It would be great if this can be part of this PR.

I'm fine with merging this into master and I can make sure dev branch catches up.

@krono

krono commented Nov 15, 2017

Copy link
Copy Markdown
Contributor Author

Hi @jbrichau

Done :)

@jbrichau

Copy link
Copy Markdown
Member

Hi @krono,
Thanks! I notice quite some tests are failing in Squeak-trunk? If we merge this in, will these be picked up later on when Squeak 6 stabilizes?

@krono

krono commented Nov 18, 2017

Copy link
Copy Markdown
Contributor Author

I think so, yes. I'll have a look later-on

@jbrichau jbrichau merged commit f28848b into SeasideSt:master Nov 18, 2017
@krono

krono commented Nov 18, 2017

Copy link
Copy Markdown
Contributor Author

Just a heads up: Most problems here exists because the pre-loaded Metacello in the Trunk-image used by smalltalkCI does not yet support squeak-Trunk. Trackin here: hpi-swa/smalltalkCI#340

@jbrichau

Copy link
Copy Markdown
Member

Does using #useLatestMetacello : true not fix that?

@krono

krono commented Nov 18, 2017

Copy link
Copy Markdown
Contributor Author

You might be right. I was not paying attention, sorry

@krono krono deleted the add-squeak6-to-baseline branch November 18, 2017 15:42
@jbrichau

Copy link
Copy Markdown
Member

No problem, I'm adding that to the .smalltalk.ston file now as I also add Pharo7 loading support.

@krono

krono commented Nov 18, 2017

Copy link
Copy Markdown
Contributor Author

👍

@jbrichau

Copy link
Copy Markdown
Member

All is green for squeak trunk 👍

@krono

krono commented Nov 19, 2017

Copy link
Copy Markdown
Contributor Author

Thats good and odd at the same time. On my machine I had one failure still, but I'm glad thats not the case on travis :)

@jbrichau

Copy link
Copy Markdown
Member

Which one? I want to make sure it runs on Travis at all.

@krono

krono commented Nov 19, 2017

Copy link
Copy Markdown
Contributor Author

Dynamic Var default value. But it just might have been a fluke, I botched the loading and loaded the packages manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants