Skip to content

Commit cdbb128

Browse files
committed
Fixing tests
1 parent 6bc9e30 commit cdbb128

2 files changed

Lines changed: 31 additions & 34 deletions

File tree

tests/GithubObject.py

Lines changed: 8 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,6 @@ def testRepoCommitGetFilesDefault(self):
356356
if lazy
357357
else [
358358
"/repos/PyGithub/PyGithub",
359-
# TODO: is that right?
360359
"/repos/PyGithub/PyGithub/commits/3253acaabd86de12b73d0a24c98eb9c13d1987b5?page=1",
361360
]
362361
)
@@ -525,24 +524,14 @@ def testRepoComparisonCommitsFiles(self):
525524
self.assertListKeyEqual(
526525
requests,
527526
lambda r: r.url,
528-
(
529-
[
530-
"/repos/PyGithub/PyGithub/compare/19e1c5032397a95c58fe25760723ffc24cbe0ec8...4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=1&per_page=2",
531-
# TODO: is that right?
532-
"/repositories/3544490/compare/19e1c5032397a95c58fe25760723ffc24cbe0ec8...4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=2&per_page=2",
533-
"/repos/PyGithub/PyGithub/commits/4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=1&per_page=2",
534-
"/repositories/3544490/commits/4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=2&per_page=2",
535-
"/repositories/3544490/commits/4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=3&per_page=2",
536-
]
537-
if lazy
538-
else [
539-
"/repos/PyGithub/PyGithub",
540-
"/repos/PyGithub/PyGithub/compare/19e1c5032397a95c58fe25760723ffc24cbe0ec8...4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=1&per_page=2",
541-
"/repos/PyGithub/PyGithub/commits/4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=1&per_page=2",
542-
"/repositories/3544490/commits/4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=2&per_page=2",
543-
"/repositories/3544490/commits/4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=3&per_page=2",
544-
]
545-
),
527+
([] if lazy else ["/repos/PyGithub/PyGithub"])
528+
+ [
529+
"/repos/PyGithub/PyGithub/compare/19e1c5032397a95c58fe25760723ffc24cbe0ec8...4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=1&per_page=2",
530+
"/repositories/3544490/compare/19e1c5032397a95c58fe25760723ffc24cbe0ec8...4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=2&per_page=2",
531+
"/repos/PyGithub/PyGithub/commits/4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=1&per_page=2",
532+
"/repositories/3544490/commits/4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=2&per_page=2",
533+
"/repositories/3544490/commits/4bf07a2f5123f78fc6759bc2ade0c74154c1ba86?page=3&per_page=2",
534+
],
546535
)
547536

548537
def testRepoComparisonCommitsFilesWithPerPage(self):
@@ -846,6 +835,3 @@ def _initAttributes(self) -> None:
846835

847836
def _useAttributes(self, attributes: Any) -> None:
848837
pass
849-
850-
851-
# TODO check replay data respect per_page

0 commit comments

Comments
 (0)