From f11607df543357bd8be1d1814a5e20d9c232608a Mon Sep 17 00:00:00 2001 From: Sergei Vorobev Date: Sat, 24 Feb 2018 13:44:02 -0600 Subject: [PATCH] Revert SecurityProtocol to original value after calling github api --- build.psm1 | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/build.psm1 b/build.psm1 index b27f2106ca6..89138c0c1d8 100644 --- a/build.psm1 +++ b/build.psm1 @@ -1684,10 +1684,14 @@ function Start-PSBootstrap { $rceditUrl = "https://github.com/electron/rcedit/releases/download/v1.0.0/rcedit-x64.exe" New-Item -Path "~/.rcedit" -Type Directory -Force > $null - ## need to specify TLS version 1.2 since GitHub API requires it - [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12 - - Invoke-WebRequest -OutFile "~/.rcedit/rcedit-x64.exe" -Uri $rceditUrl + $originalSecProtocol = [Net.ServicePointManager]::SecurityProtocol + try { + ## need to specify TLS version 1.2 since GitHub API requires it + [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12 + Invoke-WebRequest -OutFile "~/.rcedit/rcedit-x64.exe" -Uri $rceditUrl + } finally { + [Net.ServicePointManager]::SecurityProtocol = $originalSecProtocol + } } if ($BuildWindowsNative) {