From fd191eb6523564541689a0a4c8c490004ab7e20f Mon Sep 17 00:00:00 2001 From: xtqqczze Date: Thu, 12 Nov 2020 23:12:33 +0000 Subject: [PATCH 1/2] Enable CA2211: Non-constant fields should not be visible https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2211 --- .globalconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.globalconfig b/.globalconfig index 396ee24ed6e..aef14e87c69 100644 --- a/.globalconfig +++ b/.globalconfig @@ -390,7 +390,7 @@ dotnet_diagnostic.CA2207.severity = warning dotnet_diagnostic.CA2208.severity = suggestion # CA2211: Non-constant fields should not be visible -dotnet_diagnostic.CA2211.severity = suggestion +dotnet_diagnostic.CA2211.severity = warning # CA2213: Disposable fields should be disposed dotnet_diagnostic.CA2213.severity = none From 1fa74157070f5c140a430f3d4d3e864ff35bc271 Mon Sep 17 00:00:00 2001 From: xtqqczze Date: Thu, 12 Nov 2020 23:45:17 +0000 Subject: [PATCH 2/2] Suppress CA2211 in PSSessionConfigurationData --- .../engine/remoting/fanin/PSSessionConfigurationData.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/System.Management.Automation/engine/remoting/fanin/PSSessionConfigurationData.cs b/src/System.Management.Automation/engine/remoting/fanin/PSSessionConfigurationData.cs index 17aac7adfdf..6da557cca40 100644 --- a/src/System.Management.Automation/engine/remoting/fanin/PSSessionConfigurationData.cs +++ b/src/System.Management.Automation/engine/remoting/fanin/PSSessionConfigurationData.cs @@ -18,7 +18,9 @@ public sealed class PSSessionConfigurationData { /// /// +#pragma warning disable CA2211 // Non-constant fields should not be visible public static bool IsServerManager; +#pragma warning restore CA2211 // Non-constant fields should not be visible #region Public Properties