-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Remove ApartmentState support #4953
Copy link
Copy link
Closed
Labels
Committee-ReviewedPS-Committee has reviewed this and made a decisionPS-Committee has reviewed this and made a decisionIssue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalitythe issue is for cleaning up the code with no impact on functionalityResolution-Won't FixThe issue won't be fixed, possibly due to compatibility reason.The issue won't be fixed, possibly due to compatibility reason.
Metadata
Metadata
Assignees
Labels
Committee-ReviewedPS-Committee has reviewed this and made a decisionPS-Committee has reviewed this and made a decisionIssue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalitythe issue is for cleaning up the code with no impact on functionalityResolution-Won't FixThe issue won't be fixed, possibly due to compatibility reason.The issue won't be fixed, possibly due to compatibility reason.
ApartmentState STA/MTA is only used to interop with COM and not supported on non-Windows. It also seems that dotnet can marshal between STA and MTA just fine so allowing the user to set it is just a perf optimization.
I propose we simplify our code by removing support. The code base today already has ApartmentState commented out as we run MTA by default (as that is default for dotnet) so this is simply removing the
#if !CORECLRconditional code.