-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Preferred way to create completers for in-box cmdlets #25234
Copy link
Copy link
Open
Feature
0 / 10 of 1 issue completed
Copy link
Labels
Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalitythe issue is for cleaning up the code with no impact on functionalityIssue-Enhancementthe issue is more of a feature request than a bugthe issue is more of a feature request than a bugUp-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsUp-for-grabs issues are not high priorities, and may be opportunities for external contributors
Metadata
Metadata
Assignees
Labels
Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalitythe issue is for cleaning up the code with no impact on functionalityIssue-Enhancementthe issue is more of a feature request than a bugthe issue is more of a feature request than a bugUp-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsUp-for-grabs issues are not high priorities, and may be opportunities for external contributors
Summary of the new feature / enhancement
We have CompletionCompleters.cs file with gigantic size. There's a lot of code for in-box cmdlet completers. That's how it happened historically.
Now we have
ArgumentCompleterAttributeandIArgumentCompleterand it is preferable to use themThis will not only allow us to reduce the size of this file. We will be able to unify the code, remove duplication, add more tests, and distinguish common code that can be made public in the future so that users can use it in their projects.
It is also a step towards the decoupling of modules #9960
/cc @daxian-dbw @ArmaanMcleod @MartinGC94
Proposed technical implementation details (optional)
No response