Skip to content

Commit bac5aac

Browse files
authored
Removing ActiveIssue attributes. Adding component name to all WebClient tests. (dotnet/corefx#21742)
* Removing ActiveIssue attributes. Adding component name to all WebClient tests. * Revert test naming changes. Commit migrated from dotnet/corefx@b227000
1 parent 8f1199a commit bac5aac

1 file changed

Lines changed: 0 additions & 17 deletions

File tree

src/libraries/System.Net.WebClient/tests/WebClientTest.cs

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,6 @@ public static void UseDefaultCredentials_Roundtrips()
364364
}
365365
}
366366

367-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
368367
[Fact]
369368
public static async Task ResponseHeaders_ContainsHeadersAfterOperation()
370369
{
@@ -388,8 +387,6 @@ await LoopbackServer.ReadRequestAndSendResponseAsync(server,
388387
Assert.Equal("ArbitraryValue", wc.ResponseHeaders["ArbitraryHeader"]);
389388
}
390389

391-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
392-
[ActiveIssue(18680)]
393390
[OuterLoop("Networking test talking to remote server: issue #11345")]
394391
[Theory]
395392
[InlineData("Connection", "close")]
@@ -401,7 +398,6 @@ public static async Task RequestHeaders_AddDisallowedHeaderAndSendRequest_Throws
401398
await Assert.ThrowsAsync<WebException>(() => wc.DownloadStringTaskAsync(System.Net.Test.Common.Configuration.Http.RemoteEchoServer));
402399
}
403400

404-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
405401
[OuterLoop("Networking test talking to remote server: issue #11345")]
406402
[Theory]
407403
[InlineData("http://localhost", true)]
@@ -420,7 +416,6 @@ public static async Task RequestHeaders_AddHostHeaderAndSendRequest_ExpectedResu
420416
}
421417
}
422418

423-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
424419
[Fact]
425420
public static async Task RequestHeaders_SpecialHeaders_RequestSucceeds()
426421
{
@@ -444,7 +439,6 @@ await LoopbackServer.ReadRequestAndSendResponseAsync(server,
444439
});
445440
}
446441

447-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
448442
[Fact]
449443
public static async Task ConcurrentOperations_Throw()
450444
{
@@ -511,7 +505,6 @@ public abstract class WebClientTestBase
511505
protected abstract Task<Stream> OpenReadAsync(WebClient wc, string address);
512506
protected abstract Task<Stream> OpenWriteAsync(WebClient wc, string address);
513507

514-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
515508
[Theory]
516509
[InlineData(null)]
517510
[InlineData("text/html; charset=utf-8")]
@@ -537,7 +530,6 @@ await LoopbackServer.ReadRequestAndSendResponseAsync(server,
537530
});
538531
}
539532

540-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
541533
[Fact]
542534
public async Task DownloadData_Success()
543535
{
@@ -560,7 +552,6 @@ await LoopbackServer.ReadRequestAndSendResponseAsync(server,
560552
});
561553
}
562554

563-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
564555
[Fact]
565556
public async Task DownloadData_LargeData_Success()
566557
{
@@ -580,7 +571,6 @@ await LoopbackServer.ReadRequestAndSendResponseAsync(server,
580571
});
581572
}
582573

583-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
584574
[Fact]
585575
public async Task DownloadFile_Success()
586576
{
@@ -608,7 +598,6 @@ await LoopbackServer.ReadRequestAndSendResponseAsync(server,
608598
});
609599
}
610600

611-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
612601
[Fact]
613602
public async Task OpenRead_Success()
614603
{
@@ -630,7 +619,6 @@ await LoopbackServer.ReadRequestAndSendResponseAsync(server,
630619
});
631620
}
632621

633-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
634622
[OuterLoop("Networking test talking to remote server: issue #11345")]
635623
[Theory]
636624
[MemberData(nameof(EchoServers))]
@@ -644,7 +632,6 @@ public async Task OpenWrite_Success(Uri echoServer)
644632
}
645633
}
646634

647-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
648635
[OuterLoop("Networking test talking to remote server: issue #11345")]
649636
[Theory]
650637
[MemberData(nameof(EchoServers))]
@@ -660,7 +647,6 @@ public async Task UploadData_Success(Uri echoServer)
660647
Assert.True(!IsAsync || await uploadProgressInvoked.Task, "Expected upload progress callback to be invoked");
661648
}
662649

663-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
664650
[OuterLoop("Networking test talking to remote server: issue #11345")]
665651
[Theory]
666652
[MemberData(nameof(EchoServers))]
@@ -678,7 +664,6 @@ private static string GetRandomText(int length)
678664
return new string(Enumerable.Range(0, 512 * 1024).Select(_ => (char)('a' + rand.Next(0, 26))).ToArray());
679665
}
680666

681-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
682667
[OuterLoop("Networking test talking to remote server: issue #11345")]
683668
[Theory]
684669
[MemberData(nameof(EchoServers))]
@@ -698,7 +683,6 @@ public async Task UploadFile_Success(Uri echoServer)
698683
}
699684
}
700685

701-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
702686
[OuterLoop("Networking test talking to remote server: issue #11345")]
703687
[Theory]
704688
[MemberData(nameof(EchoServers))]
@@ -709,7 +693,6 @@ public async Task UploadString_Success(Uri echoServer)
709693
Assert.Contains(ExpectedText, result);
710694
}
711695

712-
[ActiveIssue(20141, TargetFrameworkMonikers.UapAot)]
713696
[OuterLoop("Networking test talking to remote server: issue #11345")]
714697
[Theory]
715698
[MemberData(nameof(EchoServers))]

0 commit comments

Comments
 (0)