From 908196a6d9e516ae70ede1093498776c38df3eba Mon Sep 17 00:00:00 2001 From: Dimitar Tachev Date: Tue, 23 Jan 2018 11:31:16 +0200 Subject: [PATCH 1/2] fix(android): handle only exceptions of the proper type on enable location --- src/geolocation.android.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/geolocation.android.ts b/src/geolocation.android.ts index 5362d82..7c5f082 100644 --- a/src/geolocation.android.ts +++ b/src/geolocation.android.ts @@ -176,9 +176,12 @@ export function enableLocationRequest(always?: boolean): Promise { _isLocationServiceEnabled().then(() => { resolve(); }, (ex) => { - let statusCode = ex.getStatusCode(); - if (statusCode === com.google.android.gms.common.api.CommonStatusCodes.RESOLUTION_REQUIRED) { + if (typeof ex.getStatusCode === "function" && + ex.getStatusCode() === com.google.android.gms.common.api.CommonStatusCodes.RESOLUTION_REQUIRED) { + try { + // cache resolve and reject callbacks in order to call them + // on REQUEST_ENABLE_LOCATION Activity Result _onEnableLocationSuccess = resolve; _onEnableLocationFail = reject; ex.startResolutionForResult(androidAppInstance.foregroundActivity, REQUEST_ENABLE_LOCATION); From 8346f02506d5633985ab12a1cc09865e58c5e288 Mon Sep 17 00:00:00 2001 From: Stoyan Stratev Date: Tue, 23 Jan 2018 13:47:42 +0200 Subject: [PATCH 2/2] chor: bump version --- src/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/package.json b/src/package.json index da833a2..e2310bc 100644 --- a/src/package.json +++ b/src/package.json @@ -1,6 +1,6 @@ { "name": "nativescript-geolocation", - "version": "4.2.2", + "version": "4.2.3", "description": "Provides API for getting and monitoring location for NativeScript app.", "main": "geolocation", "nativescript": {