From 27790e250f4975881e395bd7d08ce0f92839d0e6 Mon Sep 17 00:00:00 2001 From: Juan David Nicholls Cardona Date: Sat, 26 Jun 2021 20:33:37 -0500 Subject: [PATCH 1/3] fix(log): Allow passing arguments for logs --- packages/core/profiling/index.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/core/profiling/index.ts b/packages/core/profiling/index.ts index 927dd18f2d..2e8bebf784 100644 --- a/packages/core/profiling/index.ts +++ b/packages/core/profiling/index.ts @@ -6,11 +6,11 @@ export function uptime() { return global.android ? (org).nativescript.Process.getUpTime() : (global).__tns_uptime(); } -export function log(message: string): void { +export function log(message: string, ...args): void { if ((global).__nslog) { - (global).__nslog('CONSOLE LOG: ' + message); + (global).__nslog('CONSOLE LOG: ' + message, ...args); } - console.log(message); + console.log(message, ...args); } export type InstrumentationMode = 'counters' | 'timeline' | 'lifecycle'; From 510e5a29fda58b3fe49f2ff710073ddf92869cbe Mon Sep 17 00:00:00 2001 From: Juan David Nicholls Cardona Date: Sat, 26 Jun 2021 20:49:20 -0500 Subject: [PATCH 2/3] Rename args as optional params --- packages/core/profiling/index.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/core/profiling/index.ts b/packages/core/profiling/index.ts index 2e8bebf784..cba0f57fc1 100644 --- a/packages/core/profiling/index.ts +++ b/packages/core/profiling/index.ts @@ -6,11 +6,11 @@ export function uptime() { return global.android ? (org).nativescript.Process.getUpTime() : (global).__tns_uptime(); } -export function log(message: string, ...args): void { +export function log(message: string, ...optionalParams: any[]): void { if ((global).__nslog) { - (global).__nslog('CONSOLE LOG: ' + message, ...args); + (global).__nslog('CONSOLE LOG: ' + message, ...optionalParams); } - console.log(message, ...args); + console.log(message, ...optionalParams); } export type InstrumentationMode = 'counters' | 'timeline' | 'lifecycle'; From 44eb8a0b8eafdaceb4f4e84d8ba5637d5b94ce93 Mon Sep 17 00:00:00 2001 From: Juan David Nicholls Cardona Date: Tue, 6 Jul 2021 09:29:45 -0500 Subject: [PATCH 3/3] Don't pass optional params to NSLog --- packages/core/profiling/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/profiling/index.ts b/packages/core/profiling/index.ts index cba0f57fc1..3303939c87 100644 --- a/packages/core/profiling/index.ts +++ b/packages/core/profiling/index.ts @@ -8,7 +8,7 @@ export function uptime() { export function log(message: string, ...optionalParams: any[]): void { if ((global).__nslog) { - (global).__nslog('CONSOLE LOG: ' + message, ...optionalParams); + (global).__nslog('CONSOLE LOG: ' + message); } console.log(message, ...optionalParams); }