Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NVIDIA/physicsnemo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: NVIDIA/physicsnemo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pull-request/1766
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Jun 30, 2026

  1. Fix(geotransolver): fail fast when include_local_features=True withou…

    …t geometry
    
    GeoTransolver sizes its GALE blocks for
    effective_hidden = n_hidden + n_hidden_local * len(radii) whenever
    include_local_features=True, but the local multi-scale features are only
    produced when a geometry tensor is supplied. Omitting geometry/geometry_dim
    silently skipped the concat and surfaced as a confusing downstream
    LayerNorm shape mismatch (e.g. normalized_shape=[192] vs input 128).
    
    Add two fail-fast guards with actionable messages:
      - GeoTransolver.__init__: include_local_features=True requires geometry_dim.
      - GlobalContextBuilder.build_context: geometry is required at forward time
        when local features are enabled.
    
    Add a regression test covering both guards and the working path.
    
    Signed-off-by: Shubh Jain <shubhjain10102003@gmail.com>
    ShubhJain007 committed Jun 30, 2026
    Configuration menu
    Copy the full SHA
    dac67db View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2026

  1. Configuration menu
    Copy the full SHA
    4996f9b View commit details
    Browse the repository at this point in the history
Loading