Skip to content

Commit 348a1a3

Browse files
Reduce technical debt
1 parent fe915a2 commit 348a1a3

2 files changed

Lines changed: 16 additions & 9 deletions

File tree

src/main/java/com/profesorfalken/wmi4java/WMIPowerShell.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,13 @@
2525

2626
/**
2727
* WMI Stub implementation based in PowerShell (jPowerShell)
28-
*
28+
*
2929
* @author Javier Garcia Alonso
3030
*/
3131
class WMIPowerShell implements WMIStub {
32+
3233
private static final String NAMESPACE_PARAM = "-Namespace ";
33-
private static final String GETWMIOBJECT_COMMAND = "Get-WMIObject ";
34+
private static final String GETWMIOBJECT_COMMAND = "Get-WMIObject ";
3435

3536
private static String executeCommand(String command) throws WMIException {
3637
String commandResponse = null;
@@ -110,16 +111,19 @@ public String queryObject(String wmiClass, List<String> wmiProperties, List<Stri
110111
if (!"*".equals(namespace)) {
111112
command += NAMESPACE_PARAM + namespace;
112113
}
113-
if(wmiProperties == null ||wmiProperties.isEmpty()){
114-
wmiProperties = Collections.singletonList("*");
114+
List<String> usedWMIProperties;
115+
if (wmiProperties == null || wmiProperties.isEmpty()) {
116+
usedWMIProperties = Collections.singletonList("*");
117+
} else {
118+
usedWMIProperties = wmiProperties;
115119
}
116120

117121
command += " | ";
118122

119-
command += "Select-Object " + Joiner.on(", ").join(wmiProperties)+" -excludeproperty \"_*\" | ";
123+
command += "Select-Object " + Joiner.on(", ").join(usedWMIProperties) + " -excludeproperty \"_*\" | ";
120124

121-
if(conditions!=null && !conditions.isEmpty()){
122-
for(String condition : conditions) {
125+
if (conditions != null && !conditions.isEmpty()) {
126+
for (String condition : conditions) {
123127
command += "Where-Object -FilterScript {" + condition + "} | ";
124128
}
125129
}

src/main/java/com/profesorfalken/wmi4java/WMIVBScript.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,11 @@ public String listObject(String wmiClass, String namespace, String computerName)
158158

159159
@Override
160160
public String queryObject(String wmiClass, List<String> wmiProperties, List<String> conditions, String namespace, String computerName) throws WMIException {
161+
List<String> usedWMIProperties;
161162
if (wmiProperties == null || wmiProperties.isEmpty()) {
162-
wmiProperties = WMI4Java.get().VBSEngine().computerName(computerName).namespace(namespace).listProperties(wmiClass);
163+
usedWMIProperties = WMI4Java.get().VBSEngine().computerName(computerName).namespace(namespace).listProperties(wmiClass);
164+
} else {
165+
usedWMIProperties = wmiProperties;
163166
}
164167
try {
165168
StringBuilder scriptCode = new StringBuilder(200);
@@ -181,7 +184,7 @@ public String queryObject(String wmiClass, List<String> wmiProperties, List<Stri
181184
}
182185
scriptCode.append("\")").append(CRLF);
183186
scriptCode.append("For Each element In wmiQueryData").append(CRLF);
184-
for (final String wmiProperty : wmiProperties) {
187+
for (final String wmiProperty : usedWMIProperties) {
185188
scriptCode.append("Wscript.Echo \"").append(wmiProperty)
186189
.append(": \" & ").append("element.").append(wmiProperty).append(CRLF);
187190
}

0 commit comments

Comments
 (0)