Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: CodeYourFuture/JavaScript-Core-1-Coursework-Week1
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ManSangSin/JavaScript-Core-1-Coursework-Week1
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 7 files changed
  • 2 contributors

Commits on Feb 19, 2023

  1. completed mandatory HW 

    - completed tasks 1 - 4
    @ManSangSin
    ManSangSin committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    72d3fbd View commit details
    Browse the repository at this point in the history

  2. completed extra HW 

    - completed tasks 1 - 3
    @ManSangSin
    ManSangSin committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    d0f2346 View commit details
    Browse the repository at this point in the history

  3. Update extra/2-piping.js 

    change line to call function

Co-authored-by: Krzysztof Malinowski <krzysztof+github@malinowski.scot>
    @ManSangSin @beardedslav
    ManSangSin and beardedslav authored Feb 19, 2023
    Configuration menu
    Copy the full SHA
    3567ee6 View commit details
    Browse the repository at this point in the history

  4. made suggested changes 

    mandatory/4 - shortened math function
extra/1 - used Math.round() instead of .toFixed() so no need to convert string to number
extra/2 - changed code to call function
extra/3 - used array.length() to count array instead of hardcoding number of array items
    @ManSangSin
    ManSangSin committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    516eb4f View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Update mandatory/4-tax.js 

    Co-authored-by: Krzysztof Malinowski <krzysztof+github@malinowski.scot>
    @ManSangSin @beardedslav
    ManSangSin and beardedslav authored Feb 20, 2023
    Configuration menu
    Copy the full SHA
    6fda975 View commit details
    Browse the repository at this point in the history
Loading