Skip to content

Commit f3276fb

Browse files
timea-solidtimea-solid
committed
open new menu targets in blank (new tab) + update tests
1 parent 8c15bfa commit f3276fb

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

‎src/header/index.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,8 @@ export async function createBanner (store: IndexedFormula, pod: NamedNode, user:
9797
export function createHelpMenu () {
9898
const helpMenuList = document.createElement('ul')
9999
addStyleClassToElement(helpMenuList, ['header-user-menu__list'])
100-
helpMenuList.appendChild(createUserMenuItem(createUserMenuLink('User guide', 'https://github.com/solid/userguide')))
101-
helpMenuList.appendChild(createUserMenuItem(createUserMenuLink('Report a problem', 'https://github.com/solid/solidos/issues')))
100+
helpMenuList.appendChild(createUserMenuItem(createUserMenuLink('User guide', 'https://github.com/solid/userguide', '_blank')))
101+
helpMenuList.appendChild(createUserMenuItem(createUserMenuLink('Report a problem', 'https://github.com/solid/solidos/issues', '_blank')))
102102

103103
const helpMenu = document.createElement('nav')
104104

@@ -158,11 +158,12 @@ export function createUserMenuButton (label: string, onClick: EventListenerOrEve
158158
/**
159159
* @ignore exporting this only for the unit test
160160
*/
161-
export function createUserMenuLink (label: string, href: string): HTMLElement {
161+
export function createUserMenuLink (label: string, href: string, target?:string): HTMLElement {
162162
const link = document.createElement('a')
163163
addStyleClassToElement(link, ['header-user-menu__link'])
164164
link.href = href
165165
link.innerText = label
166+
if (target) link.target = target
166167
return link
167168
}
168169

‎test/unit/header/__snapshots__/index.test.ts.snap‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ exports[`createBanner check customized logo... 1`] = `
133133
<a
134134
class="header-user-menu__link-0-1-124"
135135
href="https://github.com/solid/userguide"
136+
target="_blank"
136137
/>
137138
</li>
138139
<li
@@ -141,6 +142,7 @@ exports[`createBanner check customized logo... 1`] = `
141142
<a
142143
class="header-user-menu__link-0-1-126"
143144
href="https://github.com/solid/solidos/issues"
145+
target="_blank"
144146
/>
145147
</li>
146148
</ul>
@@ -292,6 +294,7 @@ exports[`createBanner creates a link 1`] = `
292294
<a
293295
class="header-user-menu__link-0-1-74"
294296
href="https://github.com/solid/userguide"
297+
target="_blank"
295298
/>
296299
</li>
297300
<li
@@ -300,6 +303,7 @@ exports[`createBanner creates a link 1`] = `
300303
<a
301304
class="header-user-menu__link-0-1-76"
302305
href="https://github.com/solid/solidos/issues"
306+
target="_blank"
303307
/>
304308
</li>
305309
</ul>
@@ -335,6 +339,7 @@ exports[`createHelpMenu creates a menu.... 1`] = `
335339
<a
336340
class="header-user-menu__link-0-1-41"
337341
href="https://github.com/solid/userguide"
342+
target="_blank"
338343
/>
339344
</li>
340345
<li
@@ -343,6 +348,7 @@ exports[`createHelpMenu creates a menu.... 1`] = `
343348
<a
344349
class="header-user-menu__link-0-1-43"
345350
href="https://github.com/solid/solidos/issues"
351+
target="_blank"
346352
/>
347353
</li>
348354
</ul>

0 commit comments

Comments
 (0)