Skip to content

Commit 9910d82

Browse files
SharonStratsSharonStrats
committed
Removed snapshot tests, and parenthesis around arrow function parameter
1 parent 5e7db0e commit 9910d82

5 files changed

Lines changed: 80 additions & 76 deletions

File tree

‎.prettierrc‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"arrowParens": "always",
2+
"arrowParens": "avoid",
33
"bracketSpacing": true,
44
"htmlWhitespaceSensitivity": "css",
55
"insertPragma": false,
@@ -13,5 +13,6 @@
1313
"singleQuote": true,
1414
"tabWidth": 2,
1515
"useTabs": false,
16-
"vueIndentScriptAndStyle": false
16+
"vueIndentScriptAndStyle": false,
17+
"space-before-fuction-paren": "always"
1718
}

‎jest.config.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
module.exports = {
22
verbose: true,
3-
prettierPath: 'prettier',
43
coveragePathIgnorePatterns: ['src/test/*.js']
54
}

‎src/widgets/dragAndDrop.js‎

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,13 @@ module.exports = {
1010
}
1111
// const UI = require('../index.js') // this package
1212

13-
function makeDropTarget (ele, droppedURIHandler, droppedFileHandler) {
14-
var dragoverListener = function (e) {
13+
function makeDropTarget(ele, droppedURIHandler, droppedFileHandler) {
14+
var dragoverListener = function(e) {
1515
e.preventDefault() // Neeed else drop does not work [sic]
16-
console.log(e)
1716
e.dataTransfer.dropEffect = 'copy'
1817
}
1918

20-
var dragenterListener = function (e) {
19+
var dragenterListener = function(e) {
2120
console.log('dragenter event dropEffect: ' + e.dataTransfer.dropEffect)
2221
if (this.style) {
2322
// necessary not sure when
@@ -35,7 +34,7 @@ function makeDropTarget (ele, droppedURIHandler, droppedFileHandler) {
3534
e.dataTransfer.dropEffect = 'link'
3635
console.log('dragenter event dropEffect 2: ' + e.dataTransfer.dropEffect)
3736
}
38-
var dragleaveListener = function (e) {
37+
var dragleaveListener = function(e) {
3938
console.log('dragleave event dropEffect: ' + e.dataTransfer.dropEffect)
4039
if (this.savedStyle) {
4140
this.style.border = this.savedStyle.border
@@ -47,7 +46,7 @@ function makeDropTarget (ele, droppedURIHandler, droppedFileHandler) {
4746
}
4847
}
4948

50-
var dropListener = function (e) {
49+
var dropListener = function(e) {
5150
if (e.preventDefault) e.preventDefault() // stops the browser from redirecting off to the text.
5251
console.log('Drop event. dropEffect: ' + e.dataTransfer.dropEffect)
5352
console.log(
@@ -102,7 +101,7 @@ function makeDropTarget (ele, droppedURIHandler, droppedFileHandler) {
102101
return false
103102
} // dropListener
104103

105-
var addTargetListeners = function (ele) {
104+
var addTargetListeners = function(ele) {
106105
if (!ele) {
107106
console.log('@@@ addTargetListeners: ele ' + ele)
108107
}
@@ -118,12 +117,12 @@ function makeDropTarget (ele, droppedURIHandler, droppedFileHandler) {
118117
//
119118
// Possibly later set the drag image too?
120119
//
121-
function makeDraggable (tr, obj) {
120+
function makeDraggable(tr, obj) {
122121
tr.setAttribute('draggable', 'true') // Stop the image being dragged instead - just the TR
123122

124123
tr.addEventListener(
125124
'dragstart',
126-
function (e) {
125+
function(e) {
127126
tr.style.fontWeight = 'bold'
128127
e.dataTransfer.setData('text/uri-list', obj.uri)
129128
e.dataTransfer.setData('text/plain', obj.uri)
@@ -137,7 +136,7 @@ function makeDraggable (tr, obj) {
137136

138137
tr.addEventListener(
139138
'drag',
140-
function (e) {
139+
function(e) {
141140
e.preventDefault()
142141
e.stopPropagation()
143142
// console.log('Drag: dropEffect: ' + e.dataTransfer.dropEffect)
@@ -147,7 +146,7 @@ function makeDraggable (tr, obj) {
147146

148147
tr.addEventListener(
149148
'dragend',
150-
function (e) {
149+
function(e) {
151150
tr.style.fontWeight = 'normal'
152151
console.log('Dragend dropeffect: ' + e.dataTransfer.dropEffect)
153152
console.log('Dragend: ' + tr + ' -> ' + obj)
@@ -168,7 +167,7 @@ function makeDraggable (tr, obj) {
168167
** successHandler(file, uploadedURI) Called after each success upload
169168
** With file object an final URI as params
170169
*/
171-
function uploadFiles (fetcher, files, fileBase, imageBase, successHandler) {
170+
function uploadFiles(fetcher, files, fileBase, imageBase, successHandler) {
172171
for (var i = 0; files[i]; i++) {
173172
const f = files[i]
174173
console.log(
@@ -184,8 +183,8 @@ function uploadFiles (fetcher, files, fileBase, imageBase, successHandler) {
184183

185184
// @@ Add: progress bar(s)
186185
var reader = new FileReader()
187-
reader.onload = (function (theFile) {
188-
return function (e) {
186+
reader.onload = (function(theFile) {
187+
return function(e) {
189188
var data = e.target.result
190189
var suffix = ''
191190
console.log(' File read byteLength : ' + data.byteLength)
@@ -223,11 +222,11 @@ function uploadFiles (fetcher, files, fileBase, imageBase, successHandler) {
223222
contentType: contentType
224223
})
225224
.then(
226-
(_response) => {
225+
_response => {
227226
console.log(' Upload: put OK: ' + destURI)
228227
successHandler(theFile, destURI)
229228
},
230-
(error) => {
229+
error => {
231230
const msg = ' Upload: FAIL ' + destURI + ', Error: ' + error
232231
console.log(msg)
233232
alert(msg)

0 commit comments

Comments
 (0)