fix: build electron using NODE_ENV=production + silice bridge logs in production, closes vuejs#1151

Akryum · Akryum · commit deb5f0ec0016 · 2021-08-28T01:52:42.000+02:00
diff --git a/packages/shell-chrome/src/background.js b/packages/shell-chrome/src/background.js
@@ -39,7 +39,7 @@ function installProxy (tabId) {
     if (!res) {
       ports[tabId].devtools.postMessage('proxy-fail')
     } else {
-      console.log('injected proxy to tab ' + tabId)
+      if (process.env.NODE_ENV !== 'production') { console.log('injected proxy to tab ' + tabId) }
     }
   })
 }
@@ -50,19 +50,19 @@ function doublePipe (id, one, two) {
     if (message.event === 'log') {
       return console.log('tab ' + id, message.payload)
     }
-    console.log('devtools -> backend', message)
+    if (process.env.NODE_ENV !== 'production') { console.log('devtools -> backend', message) }
     two.postMessage(message)
   }
   two.onMessage.addListener(lTwo)
   function lTwo (message) {
     if (message.event === 'log') {
       return console.log('tab ' + id, message.payload)
     }
-    console.log('backend -> devtools', message)
+    if (process.env.NODE_ENV !== 'production') { console.log('backend -> devtools', message) }
     one.postMessage(message)
   }
   function shutdown () {
-    console.log('tab ' + id + ' disconnected.')
+    if (process.env.NODE_ENV !== 'production') { console.log('tab ' + id + ' disconnected.') }
     one.onMessage.removeListener(lOne)
     two.onMessage.removeListener(lTwo)
     one.disconnect()
@@ -71,7 +71,7 @@ function doublePipe (id, one, two) {
   }
   one.onDisconnect.addListener(shutdown)
   two.onDisconnect.addListener(shutdown)
-  console.log('tab ' + id + ' connected.')
+  if (process.env.NODE_ENV !== 'production') { console.log('tab ' + id + ' connected.') }
 }
 
 chrome.runtime.onMessage.addListener((req, sender) => {
diff --git a/packages/shell-electron/package.json b/packages/shell-electron/package.json
@@ -15,7 +15,7 @@
   "scripts": {
     "start": "node bin.js",
     "dev": "webpack --watch",
-    "build": "rm -rf ./build && webpack",
+    "build": "rm -rf ./build && cross-env NODE_ENV=production webpack",
     "prepublishOnly": "npm run build"
   },
   "author": "",

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ function installProxy (tabId) {`
`39`	`39`	`if (!res) {`
`40`	`40`	`ports[tabId].devtools.postMessage('proxy-fail')`
`41`	`41`	`} else {`
`42`		`- console.log('injected proxy to tab ' + tabId)`
	`42`	`+ if (process.env.NODE_ENV !== 'production') { console.log('injected proxy to tab ' + tabId) }`
`43`	`43`	`}`
`44`	`44`	`})`
`45`	`45`	`}`
`@@ -50,19 +50,19 @@ function doublePipe (id, one, two) {`
`50`	`50`	`if (message.event === 'log') {`
`51`	`51`	`return console.log('tab ' + id, message.payload)`
`52`	`52`	`}`
`53`		`- console.log('devtools -> backend', message)`
	`53`	`+ if (process.env.NODE_ENV !== 'production') { console.log('devtools -> backend', message) }`
`54`	`54`	`two.postMessage(message)`
`55`	`55`	`}`
`56`	`56`	`two.onMessage.addListener(lTwo)`
`57`	`57`	`function lTwo (message) {`
`58`	`58`	`if (message.event === 'log') {`
`59`	`59`	`return console.log('tab ' + id, message.payload)`
`60`	`60`	`}`
`61`		`- console.log('backend -> devtools', message)`
	`61`	`+ if (process.env.NODE_ENV !== 'production') { console.log('backend -> devtools', message) }`
`62`	`62`	`one.postMessage(message)`
`63`	`63`	`}`
`64`	`64`	`function shutdown () {`
`65`		`- console.log('tab ' + id + ' disconnected.')`
	`65`	`+ if (process.env.NODE_ENV !== 'production') { console.log('tab ' + id + ' disconnected.') }`
`66`	`66`	`one.onMessage.removeListener(lOne)`
`67`	`67`	`two.onMessage.removeListener(lTwo)`
`68`	`68`	`one.disconnect()`
`@@ -71,7 +71,7 @@ function doublePipe (id, one, two) {`
`71`	`71`	`}`
`72`	`72`	`one.onDisconnect.addListener(shutdown)`
`73`	`73`	`two.onDisconnect.addListener(shutdown)`
`74`		`- console.log('tab ' + id + ' connected.')`
	`74`	`+ if (process.env.NODE_ENV !== 'production') { console.log('tab ' + id + ' connected.') }`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`chrome.runtime.onMessage.addListener((req, sender) => {`