@typescript-eslint/no-unnecessary-qualifier

a-tarasyuk · a-tarasyuk · commit a18aeee1eb28 · 2019-06-14T12:34:28.000+03:00
diff --git a/.eslintrc b/.eslintrc
@@ -37,7 +37,7 @@
         "@typescript-eslint/no-parameter-properties": "off",
         "@typescript-eslint/no-this-alias": "error",
         "@typescript-eslint/no-triple-slash-reference": "off",
-        "@typescript-eslint/no-unnecessary-qualifier": "off",
+        "@typescript-eslint/no-unnecessary-qualifier": "error",
         "@typescript-eslint/no-unnecessary-type-assertion": "off",
         "@typescript-eslint/no-use-before-define": "off",
         "@typescript-eslint/no-var-requires": "off",
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -4977,7 +4977,8 @@ namespace ts {
                 return false;
             }
             try {
-                // tslint:disable-next-line no-unnecessary-qualifier (making clear this is a global mutation!)
+                // making clear this is a global mutation!
+                // eslint-disable-next-line @typescript-eslint/no-unnecessary-qualifier
                 ts.localizedDiagnosticMessages = JSON.parse(fileContents!);
             }
             catch {
diff --git a/src/server/protocol.ts b/src/server/protocol.ts
@@ -1,4 +1,4 @@
-// tslint:disable no-unnecessary-qualifier
+/* eslint-disable @typescript-eslint/no-unnecessary-qualifier */
 
 /**
  * Declaration module describing the TypeScript Server protocol
diff --git a/src/testRunner/unittests/incrementalParser.ts b/src/testRunner/unittests/incrementalParser.ts
@@ -1,5 +1,7 @@
 namespace ts {
-    ts.disableIncrementalParsing = false; // tslint:disable-line no-unnecessary-qualifier (make clear this is a global mutation!)
+    // make clear this is a global mutation!
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-qualifier
+    ts.disableIncrementalParsing = false;
 
     function withChange(text: IScriptSnapshot, start: number, length: number, newText: string): { text: IScriptSnapshot; textChangeRange: TextChangeRange; } {
         const contents = getSnapshotText(text);
diff --git a/src/tsserver/server.ts b/src/tsserver/server.ts
@@ -117,7 +117,7 @@ namespace ts.server {
         terminal: false,
     });
 
-    class Logger implements server.Logger { // tslint:disable-line no-unnecessary-qualifier
+    class Logger implements server.Logger { // eslint-disable-line @typescript-eslint/no-unnecessary-qualifier
         private fd = -1;
         private seq = 0;
         private inGroup = false;
diff --git a/src/typingsInstallerCore/typingsInstaller.ts b/src/typingsInstallerCore/typingsInstaller.ts
@@ -328,7 +328,9 @@ namespace ts.server.typingsInstaller {
             this.sendResponse(<BeginInstallTypes>{
                 kind: EventBeginInstallTypes,
                 eventId: requestId,
-                typingsInstallerVersion: ts.version, // tslint:disable-line no-unnecessary-qualifier (qualified explicitly to prevent occasional shadowing)
+                // qualified explicitly to prevent occasional shadowing
+                // eslint-disable-next-line @typescript-eslint/no-unnecessary-qualifier
+                typingsInstallerVersion: ts.version,
                 projectName: req.projectName
             });
 
@@ -377,7 +379,9 @@ namespace ts.server.typingsInstaller {
                         projectName: req.projectName,
                         packagesToInstall: scopedTypings,
                         installSuccess: ok,
-                        typingsInstallerVersion: ts.version // tslint:disable-line no-unnecessary-qualifier (qualified explicitly to prevent occasional shadowing)
+                        // qualified explicitly to prevent occasional shadowing
+                        // eslint-disable-next-line @typescript-eslint/no-unnecessary-qualifier
+                        typingsInstallerVersion: ts.version
                     };
                     this.sendResponse(response);
                 }

Original file line number	Diff line number	Diff line change
`@@ -4977,7 +4977,8 @@ namespace ts {`
`4977`	`4977`	`return false;`
`4978`	`4978`	`}`
`4979`	`4979`	`try {`
`4980`		`- // tslint:disable-next-line no-unnecessary-qualifier (making clear this is a global mutation!)`
	`4980`	`+ // making clear this is a global mutation!`
	`4981`	`+ // eslint-disable-next-line @typescript-eslint/no-unnecessary-qualifier`
`4981`	`4982`	`ts.localizedDiagnosticMessages = JSON.parse(fileContents!);`
`4982`	`4983`	`}`
`4983`	`4984`	`catch {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// tslint:disable no-unnecessary-qualifier`
	`1`	`+/* eslint-disable @typescript-eslint/no-unnecessary-qualifier */`
`2`	`2`
`3`	`3`	`/**`
`4`	`4`	`* Declaration module describing the TypeScript Server protocol`