Respond to CR

Benjamin Lichtman · Benjamin Lichtman · commit 6b92ccaffaa6 · 2019-05-30T17:22:12.000-07:00
diff --git a/src/compiler/resolutionCache.ts b/src/compiler/resolutionCache.ts
@@ -716,7 +716,7 @@ namespace ts {
                     }
                     // prevent saving an open file from over-eagerly triggering invalidation
                     if (resolutionHost.fileIsOpen(fileOrDirectoryPath)) {
-                        return;
+                        return false;
                     }
                     // Ignore emits from the program
                     if (isEmittedFileOfProgram(resolutionHost.getCurrentProgram(), fileOrDirectoryPath)) {
diff --git a/src/compiler/watch.ts b/src/compiler/watch.ts
@@ -691,7 +691,7 @@ namespace ts {
             hasChangedAutomaticTypeDirectiveNames = true;
             scheduleProgramUpdate();
         };
-        compilerHost.fileIsOpen = () => false;
+        compilerHost.fileIsOpen = returnFalse;
         compilerHost.maxNumberOfFilesToIterateForInvalidation = host.maxNumberOfFilesToIterateForInvalidation;
         compilerHost.getCurrentProgram = getCurrentProgram;
         compilerHost.writeLog = writeLog;

Original file line number	Diff line number	Diff line change
`@@ -716,7 +716,7 @@ namespace ts {`
`716`	`716`	`}`
`717`	`717`	`// prevent saving an open file from over-eagerly triggering invalidation`
`718`	`718`	`if (resolutionHost.fileIsOpen(fileOrDirectoryPath)) {`
`719`		`- return;`
	`719`	`+ return false;`
`720`	`720`	`}`
`721`	`721`	`// Ignore emits from the program`
`722`	`722`	`if (isEmittedFileOfProgram(resolutionHost.getCurrentProgram(), fileOrDirectoryPath)) {`