microsoft-typescript/only-arrow-functions

a-tarasyuk · a-tarasyuk · commit 0e14b4e030da · 2019-06-20T12:46:02.000+03:00
diff --git a/.eslintrc b/.eslintrc
@@ -53,7 +53,10 @@
         "microsoft-typescript/object-literal-surrounding-space": "error",
         "microsoft-typescript/no-type-assertion-whitespace": "error",
         "microsoft-typescript/type-operator-spacing": "error",
-        "microsoft-typescript/only-arrow-functions": "off",
+        "microsoft-typescript/only-arrow-functions": ["error", {
+            "allowNamedFunctions": true ,
+            "allowDeclarations": true
+        }],
         "microsoft-typescript/no-double-space": "error",
         "microsoft-typescript/boolean-trivia": "error",
         "microsoft-typescript/no-in-operator": "off",
diff --git a/scripts/authors.ts b/scripts/authors.ts
@@ -100,18 +100,18 @@ function sortAuthors(a: string, b: string) {
 }
 
 namespace Commands {
-    export const writeAuthors: Command = function () {
+    export const writeAuthors: Command = () => {
         const output = deduplicate(getKnownAuthors().map(getAuthorName).filter(a => !!a)).sort(sortAuthors).join("\r\n* ");
         fs.writeFileSync(authorsPath, "TypeScript is authored by:\r\n* " + output);
     };
     writeAuthors.description = "Write known authors to AUTHORS.md file.";
 
-    export const listKnownAuthors: Command = function () {
+    export const listKnownAuthors: Command = () => {
         deduplicate(getKnownAuthors().map(getAuthorName)).filter(a => !!a).sort(sortAuthors).forEach(log);
     };
     listKnownAuthors.description = "List known authors as listed in .mailmap file.";
 
-    export const listAuthors: Command = function (...specs: string[]) {
+    export const listAuthors: Command = (...specs: string[]) => {
         const cmd = "git shortlog -se " + specs.join(" ");
         console.log(cmd);
         const outputRegExp = /\d+\s+([^<]+)<([^>]+)>/;
@@ -137,7 +137,7 @@ namespace Commands {
 
             const maps = getKnownAuthorMaps();
 
-            const lookupAuthor = function ({name, email}: { name: string, email: string }) {
+            const lookupAuthor = ({name, email}: { name: string, email: string }) => {
                 return maps.authorsByEmail[email.toLocaleLowerCase()] || maps.authorsByName[name];
             };
 
diff --git a/scripts/importDefinitelyTypedTests/importDefinitelyTypedTests.ts b/scripts/importDefinitelyTypedTests/importDefinitelyTypedTests.ts
@@ -116,7 +116,7 @@ function importDefinitelyTypedTests(tscPath: string, rwcTestPath: string, defini
             .filter(i => fs.statSync(path.join(definitelyTypedRoot, i)).isDirectory())
             .forEach(d => {
                 const directoryPath = path.join(definitelyTypedRoot, d);
-                fs.readdir(directoryPath, function (err, files) {
+                fs.readdir(directoryPath, (err, files) => {
                     if (err) {
                         throw err;
                     }
diff --git a/scripts/word2md.ts b/scripts/word2md.ts
@@ -130,7 +130,7 @@ namespace Word {
     }
 }
 
-const sys = (function () {
+const sys = (() => {
     const fileStream = new ActiveXObject("ADODB.Stream");
     fileStream.Type = 2 /* text */;
     const binaryStream = new ActiveXObject("ADODB.Stream");
diff --git a/src/harness/harnessLanguageService.ts b/src/harness/harnessLanguageService.ts
@@ -5,7 +5,7 @@ namespace Harness.LanguageService {
         const proxy = Object.create(/*prototype*/ null);
         const langSvc: any = info.languageService;
         for (const k of Object.keys(langSvc)) {
-            // tslint:disable-next-line only-arrow-functions
+            // eslint-disable-next-line microsoft-typescript/only-arrow-functions
             proxy[k] = function () {
                 return langSvc[k].apply(langSvc, arguments);
             };
@@ -800,7 +800,7 @@ namespace Harness.LanguageService {
                             create(info: ts.server.PluginCreateInfo) {
                                 const proxy = makeDefaultProxy(info);
                                 const langSvc: any = info.languageService;
-                                // tslint:disable-next-line only-arrow-functions
+                                // eslint-disable-next-line microsoft-typescript/only-arrow-functions
                                 proxy.getQuickInfoAtPosition = function () {
                                     const parts = langSvc.getQuickInfoAtPosition.apply(langSvc, arguments);
                                     if (parts.displayParts.length > 0) {
diff --git a/src/harness/loggedIO.ts b/src/harness/loggedIO.ts
@@ -363,7 +363,7 @@ namespace Playback {
 
     function recordReplay<T extends ts.AnyFunction>(original: T, underlying: any) {
         function createWrapper(record: T, replay: T): T {
-            // tslint:disable-next-line only-arrow-functions
+            // eslint-disable-next-line microsoft-typescript/only-arrow-functions
             return <any>(function () {
                 if (replayLog !== undefined) {
                     return replay.apply(undefined, arguments);

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ function importDefinitelyTypedTests(tscPath: string, rwcTestPath: string, defini`
`116`	`116`	`.filter(i => fs.statSync(path.join(definitelyTypedRoot, i)).isDirectory())`
`117`	`117`	`.forEach(d => {`
`118`	`118`	`const directoryPath = path.join(definitelyTypedRoot, d);`
`119`		`- fs.readdir(directoryPath, function (err, files) {`
	`119`	`+ fs.readdir(directoryPath, (err, files) => {`
`120`	`120`	`if (err) {`
`121`	`121`	`throw err;`
`122`	`122`	`}`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ namespace Word {`
`130`	`130`	`}`
`131`	`131`	`}`
`132`	`132`
`133`		`-const sys = (function () {`
	`133`	`+const sys = (() => {`
`134`	`134`	`const fileStream = new ActiveXObject("ADODB.Stream");`
`135`	`135`	`fileStream.Type = 2 /* text */;`
`136`	`136`	`const binaryStream = new ActiveXObject("ADODB.Stream");`