Skip to content

Commit 2d01b2b

Browse files
committed
Merge pull request purescript#1788 from purescript/1774-unused-warnings
Better unused import warnings
2 parents eb144ec + 0e0a723 commit 2d01b2b

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

src/Language/PureScript/Linter/Imports.hs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,12 @@ findUnusedImports (Module _ _ _ mdecls mexports) env usedImps = do
7171
typesRefs
7272
= map (flip TypeRef (Just [])) typesWithoutDctors
7373
++ map (\(ty, ds) -> TypeRef ty (Just ds)) (M.toList typesWithDctors)
74-
in tell $ errorMessage $ ImplicitImport mni (classRefs ++ typesRefs ++ valueRefs)
74+
allRefs = classRefs ++ typesRefs ++ valueRefs
75+
in tell $ errorMessage $
76+
if null allRefs
77+
then UnusedImport mni
78+
else ImplicitImport mni allRefs
79+
Explicit [] -> tell $ errorMessage $ UnusedImport mni
7580
Explicit declrefs -> do
7681
let idents = nub (mapMaybe runDeclRef declrefs)
7782
let diff = idents \\ usedNames

0 commit comments

Comments
 (0)