vars to lets and const

tusharf5 · tusharf5 · commit ee84d788ddcd · 2017-11-15T13:58:45.000+05:30
diff --git a/lib/Compilation.js b/lib/Compilation.js
@@ -1425,7 +1425,7 @@ class Compilation extends Tapable {
 	}
 
 	createChildCompiler(name, outputOptions, plugins) {
-		var idx = (this.childrenCounters[name] || 0);
+		const idx = (this.childrenCounters[name] || 0);
 		this.childrenCounters[name] = idx + 1;
 		return this.compiler.createChildCompiler(this, name, idx, outputOptions, plugins);
 	}
diff --git a/lib/DllModuleFactory.js b/lib/DllModuleFactory.js
@@ -4,8 +4,8 @@
 */
 "use strict";
 
-var Tapable = require("tapable");
-var DllModule = require("./DllModule");
+const Tapable = require("tapable");
+const DllModule = require("./DllModule");
 
 class DllModuleFactory extends Tapable {
 	constructor() {
diff --git a/lib/ExternalsPlugin.js b/lib/ExternalsPlugin.js
@@ -4,7 +4,7 @@
 */
 "use strict";
 
-var ExternalModuleFactoryPlugin = require("./ExternalModuleFactoryPlugin");
+const ExternalModuleFactoryPlugin = require("./ExternalModuleFactoryPlugin");
 
 class ExternalsPlugin {
 	constructor(type, externals) {
diff --git a/lib/FlagDependencyUsagePlugin.js b/lib/FlagDependencyUsagePlugin.js
@@ -30,7 +30,7 @@ class FlagDependencyUsagePlugin {
 					else if(usedExports === true)
 						module.usedExports = true;
 					else if(Array.isArray(usedExports)) {
-						var old = module.usedExports ? module.usedExports.length : -1;
+						const old = module.usedExports ? module.usedExports.length : -1;
 						module.usedExports = addToSet(module.usedExports || [], usedExports);
 						if(module.usedExports.length === old)
 							return;
diff --git a/lib/OptionsDefaulter.js b/lib/OptionsDefaulter.js
@@ -6,7 +6,7 @@
 
 function getProperty(obj, name) {
 	name = name.split(".");
-	for(var i = 0; i < name.length - 1; i++) {
+	for(let i = 0; i < name.length - 1; i++) {
 		obj = obj[name[i]];
 		if(typeof obj !== "object" || !obj) return;
 	}
@@ -15,7 +15,7 @@ function getProperty(obj, name) {
 
 function setProperty(obj, name, value) {
 	name = name.split(".");
-	for(var i = 0; i < name.length - 1; i++) {
+	for(let i = 0; i < name.length - 1; i++) {
 		if(typeof obj[name[i]] !== "object" && typeof obj[name[i]] !== "undefined") return;
 		if(!obj[name[i]]) obj[name[i]] = {};
 		obj = obj[name[i]];
diff --git a/lib/dependencies/HarmonyDetectionParserPlugin.js b/lib/dependencies/HarmonyDetectionParserPlugin.js
@@ -9,7 +9,7 @@ const HarmonyCompatibilityDependency = require("./HarmonyCompatibilityDependency
 module.exports = class HarmonyDetectionParserPlugin {
 	apply(parser) {
 		parser.plugin("program", (ast) => {
-			var isHarmony = ast.body.some(statement => {
+			const isHarmony = ast.body.some(statement => {
 				return /^(Import|Export).*Declaration$/.test(statement.type);
 			});
 			if(isHarmony) {
@@ -32,7 +32,7 @@ module.exports = class HarmonyDetectionParserPlugin {
 				module.exportsArgument = "__webpack_exports__";
 			}
 		});
-		var nonHarmonyIdentifiers = ["define", "exports"];
+		const nonHarmonyIdentifiers = ["define", "exports"];
 		nonHarmonyIdentifiers.forEach(identifer => {
 			parser.plugin(`evaluate typeof ${identifer}`, nullInHarmony);
 			parser.plugin(`typeof ${identifer}`, skipInHarmony);
@@ -53,4 +53,7 @@ module.exports = class HarmonyDetectionParserPlugin {
 				return null;
 		}
 	}
+
+
+	
 };
diff --git a/lib/dependencies/HarmonyImportDependency.js b/lib/dependencies/HarmonyImportDependency.js
@@ -3,7 +3,7 @@
 	Author Tobias Koppers @sokra
 */
 "use strict";
-var ModuleDependency = require("./ModuleDependency");
+const ModuleDependency = require("./ModuleDependency");
 
 class HarmonyImportDependency extends ModuleDependency {
 	constructor(request, importedVar, range) {
diff --git a/lib/dependencies/LocalModulesHelpers.js b/lib/dependencies/LocalModulesHelpers.js
@@ -14,8 +14,8 @@ const lookup = (parent, mod) => {
 		segs = mod.split("/");
 	path.pop();
 
-	for(var i = 0; i < segs.length; i++) {
-		var seg = segs[i];
+	for(let i = 0; i < segs.length; i++) {
+		const seg = segs[i];
 		if(seg === "..") path.pop();
 		else if(seg !== ".") path.push(seg);
 	}
@@ -25,7 +25,7 @@ const lookup = (parent, mod) => {
 
 LocalModulesHelpers.addLocalModule = (state, name) => {
 	if(!state.localModules) state.localModules = [];
-	var m = new LocalModule(state.module, name, state.localModules.length);
+	const m = new LocalModule(state.module, name, state.localModules.length);
 	state.localModules.push(m);
 	return m;
 };
@@ -36,7 +36,7 @@ LocalModulesHelpers.getLocalModule = (state, name, namedModule) => {
 		// resolve dependency name relative to the defining named module
 		name = lookup(namedModule, name);
 	}
-	for(var i = 0; i < state.localModules.length; i++) {
+	for(let i = 0; i < state.localModules.length; i++) {
 		if(state.localModules[i].name === name)
 			return state.localModules[i];
 	}

Original file line number	Diff line number	Diff line change
`@@ -1425,7 +1425,7 @@ class Compilation extends Tapable {`
`1425`	`1425`	`}`
`1426`	`1426`
`1427`	`1427`	`createChildCompiler(name, outputOptions, plugins) {`
`1428`		`- var idx = (this.childrenCounters[name] \|\| 0);`
	`1428`	`+ const idx = (this.childrenCounters[name] \|\| 0);`
`1429`	`1429`	`this.childrenCounters[name] = idx + 1;`
`1430`	`1430`	`return this.compiler.createChildCompiler(this, name, idx, outputOptions, plugins);`
`1431`	`1431`	`}`