apply review feedback

timse · timse · commit c9fa1290d57d · 2017-03-22T23:05:22.000+11:00
diff --git a/test/configCases/records/issue-2991/pkgs/somepackage/package.json b/test/configCases/records/issue-2991/pkgs/somepackage/package.json
@@ -0,0 +1,3 @@
+{
+  "browser": { "foo": false }
+}
diff --git a/test/configCases/records/issue-2991/test.js b/test/configCases/records/issue-2991/test.js
@@ -1,5 +1,5 @@
 try {
-	require("foo");
+	require("pkgs/somepackage/foo");
 } catch(e){}
 
 it("should write relative paths to records", function() {
@@ -11,7 +11,7 @@ it("should write relative paths to records", function() {
     "byIdentifier": {
       "../../../../external \\"fs\\"": 0,
       "../../../../external \\"path\\"": 1,
-      "../../../../ignored ../test/configCases/records/issue-2991 foo": 2,
+      "../../../../ignored ../test/configCases/records/issue-2991 pkgs/somepackage/foo": 2,
       "test.js": 3
     },
     "usedIds": {
diff --git a/test/configCases/records/issue-2991/webpack.config.js b/test/configCases/records/issue-2991/webpack.config.js
@@ -7,20 +7,10 @@ module.exports = {
 	node: {
 		__dirname: false
 	},
-	plugins: [
-		{
-			apply(compiler) {
-				compiler.plugin("normal-module-factory", (nmf) => {
-					var oldResolve = nmf.resolvers.normal.resolve;
-					nmf.resolvers.normal.resolve = function(_, __, resource, callback) {
-						if(resource === "foo") {
-							callback(null, false, false);
-							return;
-						}
-						return oldResolve.apply(this, arguments);
-					};
-				});
-			}
+	resolve: {
+		aliasFields: [ "browser" ],
+		alias: {
+			pkgs: path.resolve(__dirname, "pkgs")
 		}
-	]
+	}
 };

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+{`
	`2`	`+ "browser": { "foo": false }`
	`3`	`+}`