replace glob-regex with minimatch

jevancc · jevancc · commit b620a58b403e · 2018-02-19T22:50:05.000+08:00
diff --git a/lib/optimize/SideEffectsFlagPlugin.js b/lib/optimize/SideEffectsFlagPlugin.js
@@ -4,7 +4,7 @@
 */
 "use strict";
 
-const globRegex = require("glob-regex");
+const minimatch = require("minimatch");
 const HarmonyExportImportedSpecifierDependency = require("../dependencies/HarmonyExportImportedSpecifierDependency");
 const HarmonyImportSideEffectDependency = require("../dependencies/HarmonyImportSideEffectDependency");
 const HarmonyImportSpecifierDependency = require("../dependencies/HarmonyImportSpecifierDependency");
@@ -126,7 +126,7 @@ class SideEffectsFlagPlugin {
 			case "boolean":
 				return flagValue;
 			case "string":
-				return globRegex(flagValue).test(moduleName);
+				return minimatch(moduleName, flagValue);
 			case "object":
 				return flagValue.some(glob => SideEffectsFlagPlugin.moduleHasSideEffects(moduleName, glob));
 		}
diff --git a/package.json b/package.json
@@ -12,10 +12,10 @@
     "chrome-trace-event": "^0.1.1",
     "enhanced-resolve": "^4.0.0-beta.2",
     "eslint-scope": "^3.7.1",
-    "glob-regex": "^0.2.2",
     "loader-runner": "^2.3.0",
     "loader-utils": "^1.1.0",
     "memory-fs": "~0.4.1",
+    "minimatch": "^3.0.4",
     "mkdirp": "~0.5.0",
     "neo-async": "^2.5.0",
     "node-libs-browser": "^2.0.0",
diff --git a/yarn.lock b/yarn.lock
@@ -1620,10 +1620,6 @@ glob-parent@^2.0.0:
   dependencies:
     is-glob "^2.0.0"
 
-glob-regex@^0.2.2:
-  version "0.2.2"
-  resolved "https://registry.yarnpkg.com/glob-regex/-/glob-regex-0.2.2.tgz#43dc4b0d986a394c7770a99802367d8300370977"
-
 glob@7.1.1:
   version "7.1.1"
   resolved "https://registry.yarnpkg.com/glob/-/glob-7.1.1.tgz#805211df04faaf1c63a3600306cdf5ade50b2ec8"
