stricter linting and bug fixes

sokra · sokra · commit afd11259b21f · 2016-09-15T00:22:10.000+02:00
diff --git a/.eslintrc b/.eslintrc
@@ -15,6 +15,7 @@
 		"no-process-exit": 1,
 		"no-underscore-dangle": 0,
 		"no-use-before-define": 0,
+		"no-undef": 2,
 		"no-unused-vars": 0,
 		"consistent-return": 0,
 		"no-inner-declarations": 1,
diff --git a/lib/HotModuleReplacement.runtime.js b/lib/HotModuleReplacement.runtime.js
@@ -2,7 +2,7 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
-/*global $hash$ installedModules $require$ hotDownloadManifest hotDownloadUpdateChunk modules */
+/*global $hash$ installedModules $require$ hotDownloadManifest hotDownloadUpdateChunk hotDisposeChunk modules */
 module.exports = function() {
 
 	var hotApplyOnUpdate = true;
diff --git a/lib/WebpackOptionsApply.js b/lib/WebpackOptionsApply.js
@@ -286,16 +286,3 @@ WebpackOptionsApply.prototype.process = function(options, compiler) {
 	compiler.applyPlugins("after-resolvers", compiler);
 	return options;
 };
-
-function makeRootPlugin(name, root) {
-	if(typeof root === "string")
-		return new ModulesInRootPlugin(name, root);
-	else if(Array.isArray(root)) {
-		return function() {
-			root.forEach(function(root) {
-				this.apply(new ModulesInRootPlugin(name, root));
-			}, this);
-		};
-	}
-	return function() {};
-}
diff --git a/lib/node/NodeMainTemplate.runtime.js b/lib/node/NodeMainTemplate.runtime.js
@@ -2,7 +2,7 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
-/*global $hotChunkFilename$ hotAddUpdateChunk $hotMainFilename$ */
+/*global installedChunks $hotChunkFilename$ hotAddUpdateChunk $hotMainFilename$ */
 module.exports = function() {
 	function hotDownloadUpdateChunk(chunkId) { // eslint-disable-line no-unused-vars
 		var chunk = require("./" + $hotChunkFilename$);
@@ -18,7 +18,7 @@ module.exports = function() {
 		return Promise.resolve(update);
 	}
 
-	function hotDiposeChunk(chunkId) {
+	function hotDisposeChunk(chunkId) {
 		delete installedChunks[chunkId];
 	}
 };
diff --git a/lib/node/NodeMainTemplateAsync.runtime.js b/lib/node/NodeMainTemplateAsync.runtime.js
@@ -2,7 +2,7 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
-/*global $hotChunkFilename$ $require$ hotAddUpdateChunk $hotMainFilename$ */
+/*global installedChunks $hotChunkFilename$ $require$ hotAddUpdateChunk $hotMainFilename$ */
 module.exports = function() {
 	function hotDownloadUpdateChunk(chunkId) { // eslint-disable-line no-unused-vars
 		var filename = require("path").join(__dirname, $hotChunkFilename$);
@@ -34,7 +34,7 @@ module.exports = function() {
 		});
 	}
 
-	function hotDiposeChunk(chunkId) {
+	function hotDisposeChunk(chunkId) {
 		delete installedChunks[chunkId];
 	}
 };
diff --git a/lib/webworker/WebWorkerMainTemplate.runtime.js b/lib/webworker/WebWorkerMainTemplate.runtime.js
@@ -2,7 +2,7 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
-/*globals hotAddUpdateChunk parentHotUpdateCallback importScripts XMLHttpRequest $require$ $hotChunkFilename$ $hotMainFilename$ */
+/*globals installedChunks hotAddUpdateChunk parentHotUpdateCallback importScripts XMLHttpRequest $require$ $hotChunkFilename$ $hotMainFilename$ */
 module.exports = function() {
 	function webpackHotUpdateCallback(chunkId, moreModules) { // eslint-disable-line no-unused-vars
 		hotAddUpdateChunk(chunkId, moreModules);
@@ -49,7 +49,7 @@ module.exports = function() {
 		};
 	}
 
-	function hotDiposeChunk(chunkId) {
+	function hotDisposeChunk(chunkId) {
 		delete installedChunks[chunkId];
 	}
 };
