fixed webpack#1650

sokra · sokra · commit 684f02cbce6d · 2016-02-04T08:49:08.000+01:00
diff --git a/lib/HotModuleReplacement.runtime.js b/lib/HotModuleReplacement.runtime.js
@@ -29,7 +29,10 @@ module.exports = function() {
 		};
 		for(var name in $require$) {
 			if(Object.prototype.hasOwnProperty.call($require$, name)) {
-				fn[name] = $require$[name];
+				Object.defineProperty(fn, name, {
+					get: function() { return $require$[name]; },
+					set: function(value) { $require$[name] = value; }
+				});
 			}
 		}
 		fn.e = function(chunkId) {
diff --git a/test/cases/runtime/issue-1650/file.js b/test/cases/runtime/issue-1650/file.js
@@ -0,0 +1 @@
+__webpack_public_path__ = "ok";
diff --git a/test/cases/runtime/issue-1650/index.js b/test/cases/runtime/issue-1650/index.js
@@ -0,0 +1,6 @@
+it("should be able to set the public path globally", function() {
+	var org = __webpack_public_path__;
+	require("./file");
+	__webpack_public_path__.should.be.eql("ok");
+	__webpack_public_path__ = org;
+});

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,10 @@ module.exports = function() {`
`29`	`29`	`};`
`30`	`30`	`for(var name in $require$) {`
`31`	`31`	`if(Object.prototype.hasOwnProperty.call($require$, name)) {`
`32`		`- fn[name] = $require$[name];`
	`32`	`+ Object.defineProperty(fn, name, {`
	`33`	`+ get: function() { return $require$[name]; },`
	`34`	`+ set: function(value) { $require$[name] = value; }`
	`35`	`+ });`
`33`	`36`	`}`
`34`	`37`	`}`
`35`	`38`	`fn.e = function(chunkId) {`