display a note about the breaking change when forgot the -loader prefix

sokra · sokra · commit 5803fd7fe374 · 2016-11-14T21:25:26.000+01:00
diff --git a/lib/NormalModuleFactory.js b/lib/NormalModuleFactory.js
@@ -213,6 +213,16 @@ NormalModuleFactory.prototype.resolveRequestArray = function resolveRequestArray
 	if(array.length === 0) return callback(null, []);
 	async.map(array, function(item, callback) {
 		resolver.resolve(contextInfo, context, item.loader, function(err, result) {
+			if(err && /^[^/]*$/.test(item.loader) && !/-loader$/.test(item.loader)) {
+				return resolver.resolve(contextInfo, context, item.loader + "-loader", function(err2) {
+					if(!err2) {
+						err.message = err.message + "\n" +
+							"BREAKING CHANGE: It's no longer allowed to omit the '-loader' prefix when using loaders.\n" +
+							"                 You need to specify '" + item.loader + "-loader' instead of '" + item.loader + "'.";
+					}
+					callback(err);
+				});
+			}
 			if(err) return callback(err);
 			return callback(null, objectAssign({}, item, {
 				loader: result
diff --git a/test/cases/resolving/issue-2986/errors.js b/test/cases/resolving/issue-2986/errors.js
@@ -0,0 +1,4 @@
+module.exports = [
+	[/Can't resolve 'any' in/, /BREAKING CHANGE/, /any-loader/],
+	[/Can't resolve 'other' in/]
+];
diff --git a/test/cases/resolving/issue-2986/index.js b/test/cases/resolving/issue-2986/index.js
@@ -0,0 +1,4 @@
+require.include("any!");
+require.include("other!");
+
+it("should have correct errors", function() {})
diff --git a/test/cases/resolving/issue-2986/node_modules/any-loader.js b/test/cases/resolving/issue-2986/node_modules/any-loader.js
