fixed another bug with the CommonsChunkPlugin

sokra · sokra · commit 181da3c004bd · 2015-11-20T21:29:32.000+01:00
when using multiple commons chunks
other optimization plugins doesn't optimize perfectly
diff --git a/lib/optimize/CommonsChunkPlugin.js b/lib/optimize/CommonsChunkPlugin.js
@@ -2,6 +2,8 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
+var nextIdent = 0;
+
 function CommonsChunkPlugin(options, filenameTemplate, selectedChunks, minChunks) {
 	if(options && typeof options === "object" && !Array.isArray(options)) {
 		this.chunkNames = options.name || options.names;
@@ -27,7 +29,9 @@ function CommonsChunkPlugin(options, filenameTemplate, selectedChunks, minChunks
 		this.minChunks = minChunks;
 		this.selectedChunks = selectedChunks;
 	}
+	this.ident = __filename + (nextIdent++);
 }
+
 module.exports = CommonsChunkPlugin;
 CommonsChunkPlugin.prototype.apply = function(compiler) {
 	var chunkNames = this.chunkNames;
@@ -36,8 +40,13 @@ CommonsChunkPlugin.prototype.apply = function(compiler) {
 	var selectedChunks = this.selectedChunks;
 	var async = this.async;
 	var minSize = this.minSize;
+	var ident = this.ident;
 	compiler.plugin("this-compilation", function(compilation) {
 		compilation.plugin(["optimize-chunks", "optimize-extracted-chunks"], function(chunks) {
+			// only optimize once
+			if(compilation[ident]) return;
+			compilation[ident] = true;
+
 			var commonChunks;
 			if(!chunkNames && (selectedChunks === false || async)) {
 				commonChunks = chunks;
@@ -163,6 +172,7 @@ CommonsChunkPlugin.prototype.apply = function(compiler) {
 				if(filenameTemplate)
 					commonChunk.filenameTemplate = filenameTemplate;
 			}, this);
+			this.restartApplyPlugins();
 		});
 	});
 };
