Skip to content

Commit fa5885f

Browse files
rjepsteinrjepstein
committed
Unreviewed, rolling out r250030.
Cause of Recent Build Failures. Reverted changeset: "Make all ScriptWrappable IsoHeap-ed" https://bugs.webkit.org/show_bug.cgi?id=201846 https://trac.webkit.org/changeset/250030 Canonical link: https://commits.webkit.org/215565@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent e45ead3 commit fa5885f

161 files changed

Lines changed: 31 additions & 598 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎Source/WebCore/ChangeLog‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
2019-09-18 Russell Epstein <repstein@apple.com>
2+
3+
Unreviewed, rolling out r250030.
4+
5+
Cause of Recent Build Failures.
6+
7+
Reverted changeset:
8+
9+
"Make all ScriptWrappable IsoHeap-ed"
10+
https://bugs.webkit.org/show_bug.cgi?id=201846
11+
https://trac.webkit.org/changeset/250030
12+
113
2019-09-18 Zalan Bujtas <zalan@apple.com>
214

315
[LFC] FormattingContext::Geometry::computedHeight* functions need containingBlockHeight only.

‎Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.cpp‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,12 @@
2626
#include "config.h"
2727
#include "WebKitPlaybackTargetAvailabilityEvent.h"
2828

29-
#include <wtf/IsoMallocInlines.h>
3029
#include <wtf/NeverDestroyed.h>
3130

3231
#if ENABLE(WIRELESS_PLAYBACK_TARGET)
3332

3433
namespace WebCore {
3534

36-
WTF_MAKE_ISO_ALLOCATED_IMPL(WebKitPlaybackTargetAvailabilityEvent);
37-
3835
static const AtomString& stringForPlaybackTargetAvailability(bool available)
3936
{
4037
static NeverDestroyed<AtomString> availableString("available", AtomString::ConstructFromLiteral);

‎Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@
3131

3232
namespace WebCore {
3333

34-
class WebKitPlaybackTargetAvailabilityEvent final : public Event {
35-
WTF_MAKE_ISO_ALLOCATED(WebKitPlaybackTargetAvailabilityEvent);
34+
class WebKitPlaybackTargetAvailabilityEvent : public Event {
3635
public:
3736

3837
static Ref<WebKitPlaybackTargetAvailabilityEvent> create(const AtomString& eventType, bool available)

‎Source/WebCore/Modules/applepay/ApplePayPaymentAuthorizedEvent.cpp‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,9 @@
2929
#if ENABLE(APPLE_PAY)
3030

3131
#include "Payment.h"
32-
#include <wtf/IsoMallocInlines.h>
3332

3433
namespace WebCore {
3534

36-
WTF_MAKE_ISO_ALLOCATED_IMPL(ApplePayPaymentAuthorizedEvent);
37-
3835
ApplePayPaymentAuthorizedEvent::ApplePayPaymentAuthorizedEvent(const AtomString& type, unsigned version, const Payment& payment)
3936
: Event(type, CanBubble::No, IsCancelable::No)
4037
, m_payment(payment.toApplePayPayment(version))

‎Source/WebCore/Modules/applepay/ApplePayPaymentAuthorizedEvent.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ namespace WebCore {
3535
class Payment;
3636

3737
class ApplePayPaymentAuthorizedEvent final : public Event {
38-
WTF_MAKE_ISO_ALLOCATED(ApplePayPaymentAuthorizedEvent);
3938
public:
4039
static Ref<ApplePayPaymentAuthorizedEvent> create(const AtomString& type, unsigned version, const Payment& payment)
4140
{

‎Source/WebCore/Modules/applepay/ApplePayPaymentMethodSelectedEvent.cpp‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,9 @@
2929
#if ENABLE(APPLE_PAY)
3030

3131
#include "PaymentMethod.h"
32-
#include <wtf/IsoMallocInlines.h>
3332

3433
namespace WebCore {
3534

36-
WTF_MAKE_ISO_ALLOCATED_IMPL(ApplePayPaymentMethodSelectedEvent);
37-
3835
ApplePayPaymentMethodSelectedEvent::ApplePayPaymentMethodSelectedEvent(const AtomString& type, const PaymentMethod& paymentMethod)
3936
: Event(type, CanBubble::No, IsCancelable::No)
4037
, m_paymentMethod(paymentMethod.toApplePayPaymentMethod())

‎Source/WebCore/Modules/applepay/ApplePayPaymentMethodSelectedEvent.h‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ namespace WebCore {
3434

3535
class PaymentMethod;
3636

37-
class ApplePayPaymentMethodSelectedEvent final : public Event {
38-
WTF_MAKE_ISO_ALLOCATED(ApplePayPaymentMethodSelectedEvent);
37+
class ApplePayPaymentMethodSelectedEvent : public Event {
3938
public:
4039
static Ref<ApplePayPaymentMethodSelectedEvent> create(const AtomString& type, const PaymentMethod& paymentMethod)
4140
{

‎Source/WebCore/Modules/applepay/ApplePayShippingContactSelectedEvent.cpp‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,9 @@
2929
#if ENABLE(APPLE_PAY)
3030

3131
#include "PaymentContact.h"
32-
#include <wtf/IsoMallocInlines.h>
3332

3433
namespace WebCore {
3534

36-
WTF_MAKE_ISO_ALLOCATED_IMPL(ApplePayShippingContactSelectedEvent);
37-
3835
ApplePayShippingContactSelectedEvent::ApplePayShippingContactSelectedEvent(const AtomString& type, unsigned version, const PaymentContact& shippingContact)
3936
: Event(type, CanBubble::No, IsCancelable::No)
4037
, m_shippingContact(shippingContact.toApplePayPaymentContact(version))

‎Source/WebCore/Modules/applepay/ApplePayShippingContactSelectedEvent.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ namespace WebCore {
3535
class PaymentContact;
3636

3737
class ApplePayShippingContactSelectedEvent final : public Event {
38-
WTF_MAKE_ISO_ALLOCATED(ApplePayShippingContactSelectedEvent);
3938
public:
4039
static Ref<ApplePayShippingContactSelectedEvent> create(const AtomString& type, unsigned version, const PaymentContact& shippingContact)
4140
{

‎Source/WebCore/Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,10 @@
2828

2929
#if ENABLE(APPLE_PAY)
3030

31-
#include <wtf/IsoMallocInlines.h>
3231
#include <wtf/text/StringBuilder.h>
3332

3433
namespace WebCore {
3534

36-
WTF_MAKE_ISO_ALLOCATED_IMPL(ApplePayShippingMethodSelectedEvent);
37-
3835
static inline ApplePayShippingMethod convert(const ApplePaySessionPaymentRequest::ShippingMethod& shippingMethod)
3936
{
4037
ApplePayShippingMethod convertedMethod;

0 commit comments

Comments
 (0)