Respond to PR feedback

Andy Hanson · Andy Hanson · commit f11dbc1ad160 · 2016-10-19T06:26:50.000-07:00
diff --git a/src/compiler/comments.ts b/src/compiler/comments.ts
@@ -182,9 +182,9 @@ namespace ts {
             }
         }
 
-        function emitTripleSlashLeadingComment(commentPos: number, commentEnd: number, _kind: SyntaxKind, hasTrailingNewLine: boolean, rangePos: number) {
+        function emitTripleSlashLeadingComment(commentPos: number, commentEnd: number, kind: SyntaxKind, hasTrailingNewLine: boolean, rangePos: number) {
             if (isTripleSlashComment(commentPos, commentEnd)) {
-                emitLeadingComment(commentPos, commentEnd, _kind, hasTrailingNewLine, rangePos);
+                emitLeadingComment(commentPos, commentEnd, kind, hasTrailingNewLine, rangePos);
             }
         }
 
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -903,7 +903,7 @@ namespace ts {
             return t => compose(a(t));
         }
         else {
-            return _t => u => u;
+            return _ => u => u;
         }
     }
 
diff --git a/src/compiler/emitter.ts b/src/compiler/emitter.ts
@@ -14,7 +14,7 @@ namespace ts {
     }
 
     const id = (s: SourceFile) => s;
-    const nullTransformers: Transformer[] = [_ctx => id];
+    const nullTransformers: Transformer[] = [_ => id];
 
     // targetSourceFile is when users only want one file in entire project to be emitted. This is used in compileOnSave feature
     export function emitFiles(resolver: EmitResolver, host: EmitHost, targetSourceFile: SourceFile, emitOnlyDtsFiles?: boolean): EmitResult {
diff --git a/src/compiler/moduleNameResolver.ts b/src/compiler/moduleNameResolver.ts
@@ -5,7 +5,7 @@ namespace ts {
 
     /* @internal */
     export function trace(host: ModuleResolutionHost, message: DiagnosticMessage, ...args: any[]): void;
-    export function trace(host: ModuleResolutionHost, _message: DiagnosticMessage): void {
+    export function trace(host: ModuleResolutionHost): void {
         host.trace(formatMessage.apply(undefined, arguments));
     }
 
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -572,10 +572,10 @@ namespace ts {
         // attached to the EOF token.
         let parseErrorBeforeNextFinishedNode = false;
 
-        export function parseSourceFile(fileName: string, _sourceText: string, languageVersion: ScriptTarget, _syntaxCursor: IncrementalParser.SyntaxCursor, setParentNodes?: boolean, scriptKind?: ScriptKind): SourceFile {
+        export function parseSourceFile(fileName: string, sourceText: string, languageVersion: ScriptTarget, syntaxCursor: IncrementalParser.SyntaxCursor, setParentNodes?: boolean, scriptKind?: ScriptKind): SourceFile {
             scriptKind = ensureScriptKind(fileName, scriptKind);
 
-            initializeState(_sourceText, languageVersion, _syntaxCursor, scriptKind);
+            initializeState(sourceText, languageVersion, syntaxCursor, scriptKind);
 
             const result = parseSourceFileWorker(fileName, languageVersion, setParentNodes, scriptKind);
 
diff --git a/src/compiler/sys.ts b/src/compiler/sys.ts
@@ -591,7 +591,7 @@ namespace ts {
                 getExecutingFilePath: () => ChakraHost.executingFile,
                 getCurrentDirectory: () => ChakraHost.currentDirectory,
                 getDirectories: ChakraHost.getDirectories,
-                getEnvironmentVariable: ChakraHost.getEnvironmentVariable || ((_name: string) => ""),
+                getEnvironmentVariable: ChakraHost.getEnvironmentVariable || (() => ""),
                 readDirectory: (path: string, extensions?: string[], excludes?: string[], includes?: string[]) => {
                     const pattern = getFileMatcherPatterns(path, excludes, includes, !!ChakraHost.useCaseSensitiveFileNames, ChakraHost.currentDirectory);
                     return ChakraHost.readDirectory(path, extensions, pattern.basePaths, pattern.excludePattern, pattern.includeFilePattern, pattern.includeDirectoryPattern);

Original file line number	Diff line number	Diff line change
`@@ -182,9 +182,9 @@ namespace ts {`
`182`	`182`	`}`
`183`	`183`	`}`
`184`	`184`
`185`		`- function emitTripleSlashLeadingComment(commentPos: number, commentEnd: number, _kind: SyntaxKind, hasTrailingNewLine: boolean, rangePos: number) {`
	`185`	`+ function emitTripleSlashLeadingComment(commentPos: number, commentEnd: number, kind: SyntaxKind, hasTrailingNewLine: boolean, rangePos: number) {`
`186`	`186`	`if (isTripleSlashComment(commentPos, commentEnd)) {`
`187`		`- emitLeadingComment(commentPos, commentEnd, _kind, hasTrailingNewLine, rangePos);`
	`187`	`+ emitLeadingComment(commentPos, commentEnd, kind, hasTrailingNewLine, rangePos);`
`188`	`188`	`}`
`189`	`189`	`}`
`190`	`190`
Original file line number	Diff line number	Diff line change
`@@ -903,7 +903,7 @@ namespace ts {`
`903`	`903`	`return t => compose(a(t));`
`904`	`904`	`}`
`905`	`905`	`else {`
`906`		`- return _t => u => u;`
	`906`	`+ return _ => u => u;`
`907`	`907`	`}`
`908`	`908`	`}`
`909`	`909`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ namespace ts {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`const id = (s: SourceFile) => s;`
`17`		`- const nullTransformers: Transformer[] = [_ctx => id];`
	`17`	`+ const nullTransformers: Transformer[] = [_ => id];`
`18`	`18`
`19`	`19`	`// targetSourceFile is when users only want one file in entire project to be emitted. This is used in compileOnSave feature`
`20`	`20`	`export function emitFiles(resolver: EmitResolver, host: EmitHost, targetSourceFile: SourceFile, emitOnlyDtsFiles?: boolean): EmitResult {`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ namespace ts {`
`5`	`5`
`6`	`6`	`/* @internal */`
`7`	`7`	`export function trace(host: ModuleResolutionHost, message: DiagnosticMessage, ...args: any[]): void;`
`8`		`- export function trace(host: ModuleResolutionHost, _message: DiagnosticMessage): void {`
	`8`	`+ export function trace(host: ModuleResolutionHost): void {`
`9`	`9`	`host.trace(formatMessage.apply(undefined, arguments));`
`10`	`10`	`}`
`11`	`11`