Add @deprecated to tree walk (microsoft#43473)

sandersn · web-flow · commit c6a2e4576845 · 2021-04-01T08:42:00.000-07:00
So various things don't crash. Fixes microsoft#43472
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -551,6 +551,7 @@ namespace ts {
             case SyntaxKind.JSDocPrivateTag:
             case SyntaxKind.JSDocProtectedTag:
             case SyntaxKind.JSDocReadonlyTag:
+            case SyntaxKind.JSDocDeprecatedTag:
                 return visitNode(cbNode, (node as JSDocTag).tagName)
                  || (typeof (node as JSDoc).comment === "string" ? undefined : visitNodes(cbNode, cbNodes, (node as JSDoc).comment as NodeArray<JSDocText | JSDocLink> | undefined));
             case SyntaxKind.PartiallyEmittedExpression:
diff --git a/tests/baselines/reference/quickInfoInheritedLinkTag.baseline b/tests/baselines/reference/quickInfoInheritedLinkTag.baseline
@@ -0,0 +1,111 @@
+[
+  {
+    "marker": {
+      "fileName": "/tests/cases/fourslash/quickInfoInheritedLinkTag.ts",
+      "position": 258,
+      "name": ""
+    },
+    "quickInfo": {
+      "kind": "method",
+      "kindModifiers": "deprecated",
+      "textSpan": {
+        "start": 257,
+        "length": 1
+      },
+      "displayParts": [
+        {
+          "text": "(",
+          "kind": "punctuation"
+        },
+        {
+          "text": "method",
+          "kind": "text"
+        },
+        {
+          "text": ")",
+          "kind": "punctuation"
+        },
+        {
+          "text": " ",
+          "kind": "space"
+        },
+        {
+          "text": "C",
+          "kind": "className"
+        },
+        {
+          "text": ".",
+          "kind": "punctuation"
+        },
+        {
+          "text": "m",
+          "kind": "methodName"
+        },
+        {
+          "text": "(",
+          "kind": "punctuation"
+        },
+        {
+          "text": ")",
+          "kind": "punctuation"
+        },
+        {
+          "text": ":",
+          "kind": "punctuation"
+        },
+        {
+          "text": " ",
+          "kind": "space"
+        },
+        {
+          "text": "void",
+          "kind": "keyword"
+        }
+      ],
+      "documentation": [],
+      "tags": [
+        {
+          "name": "deprecated",
+          "text": [
+            {
+              "text": "Use ",
+              "kind": "text"
+            },
+            {
+              "text": "{@link ",
+              "kind": "link"
+            },
+            {
+              "text": "PerspectiveCamera#setFocalLength .setFocalLength()",
+              "kind": "linkText"
+            },
+            {
+              "text": "}",
+              "kind": "link"
+            },
+            {
+              "text": " and ",
+              "kind": "text"
+            },
+            {
+              "text": "{@link ",
+              "kind": "link"
+            },
+            {
+              "text": "PerspectiveCamera#filmGauge .filmGauge",
+              "kind": "linkText"
+            },
+            {
+              "text": "}",
+              "kind": "link"
+            },
+            {
+              "text": " instead.",
+              "kind": "text"
+            }
+          ]
+        }
+      ]
+    }
+  }
+]
diff --git a/tests/cases/fourslash/quickInfoInheritedLinkTag.ts b/tests/cases/fourslash/quickInfoInheritedLinkTag.ts
@@ -0,0 +1,15 @@
+///<reference path="fourslash.ts" />
+
+//// export class C {
+////      /**
+////       * @deprecated Use {@link PerspectiveCamera#setFocalLength .setFocalLength()} and {@link PerspectiveCamera#filmGauge .filmGauge} instead.
+////       */
+////     m() { }
+//// }
+//// export class D extends C {
+////     m() { } // crashes here
+//// }
+//// new C().m/**/ // and here (with a different thing trying to access undefined)
+
+verify.noErrors()
+verify.baselineQuickInfo();
