Merge pull request microsoft#32668 from orta/fix_31209

Orta · web-flow · commit b70f89488193 · 2019-08-08T08:56:35.000-07:00
Suppress console.log &amp; others inside the TS Server runtime so that language service plugins don't accidentally use them and kill the server
diff --git a/src/tsserver/server.ts b/src/tsserver/server.ts
@@ -982,4 +982,12 @@ namespace ts.server {
     if (ts.sys.tryEnableSourceMapsForHost && /^development$/i.test(ts.sys.getEnvironmentVariable("NODE_ENV"))) {
         ts.sys.tryEnableSourceMapsForHost();
     }
+
+    // Overwrites the current console messages to instead write to
+    // the log. This is so that language service plugins which use
+    // console.log don't break the message passing between tsserver
+    // and the client
+    console.log = (...args) => logger.msg(args.length === 1 ? args[0] : args.join(", "), Msg.Info);
+    console.warn = (...args) => logger.msg(args.length === 1 ? args[0] : args.join(", "), Msg.Err);
+    console.error = (...args) => logger.msg(args.length === 1 ? args[0] : args.join(", "), Msg.Err);
 }

Original file line number	Diff line number	Diff line change
`@@ -982,4 +982,12 @@ namespace ts.server {`
`982`	`982`	`if (ts.sys.tryEnableSourceMapsForHost && /^development$/i.test(ts.sys.getEnvironmentVariable("NODE_ENV"))) {`
`983`	`983`	`ts.sys.tryEnableSourceMapsForHost();`
`984`	`984`	`}`
	`985`	`+`
	`986`	`+ // Overwrites the current console messages to instead write to`
	`987`	`+ // the log. This is so that language service plugins which use`
	`988`	`+ // console.log don't break the message passing between tsserver`
	`989`	`+ // and the client`
	`990`	`+ console.log = (...args) => logger.msg(args.length === 1 ? args[0] : args.join(", "), Msg.Info);`
	`991`	`+ console.warn = (...args) => logger.msg(args.length === 1 ? args[0] : args.join(", "), Msg.Err);`
	`992`	`+ console.error = (...args) => logger.msg(args.length === 1 ? args[0] : args.join(", "), Msg.Err);`
`985`	`993`	`}`