Fixes searches for export * as 'identifier' (microsoft#39533)

sheetalkamat · web-flow · commit b397d1fd4abd · 2020-07-09T13:45:43.000-07:00
* Fixes searches for export * as 'identifier' Fixes microsoft#39006 * Fix the context span to export declaration (was incorrectly set to sourceFile in prev commit)
diff --git a/src/services/findAllReferences.ts b/src/services/findAllReferences.ts
@@ -132,6 +132,7 @@ namespace ts.FindAllReferences {
                 return node.parent.parent;
 
             case SyntaxKind.ImportClause:
+            case SyntaxKind.NamespaceExport:
                 return node.parent;
 
             case SyntaxKind.BinaryExpression:
diff --git a/src/services/importTracker.ts b/src/services/importTracker.ts
@@ -481,6 +481,9 @@ namespace ts.FindAllReferences {
                         return exportInfo(symbol, getExportKindForDeclaration(exportNode));
                     }
                 }
+                else if (isNamespaceExport(parent)) {
+                    return exportInfo(symbol, ExportKind.Named);
+                }
                 // If we are in `export = a;` or `export default a;`, `parent` is the export assignment.
                 else if (isExportAssignment(parent)) {
                     return getExportAssignmentExport(parent);
diff --git a/tests/cases/fourslash/findAllRefsReExportStarAs.ts b/tests/cases/fourslash/findAllRefsReExportStarAs.ts
@@ -1,16 +1,20 @@
 /// <reference path="fourslash.ts" />
 
 // @Filename: /leafModule.ts
-////[|export const [|{| "isWriteAccess": true, "isDefinition": true, "contextRangeIndex": 0 |}hello|] = () => 'Hello';|]
+////[|{| "id": "helloDecl" |}export const [|{| "isWriteAccess": true, "isDefinition": true, "contextRangeId": "helloDecl" |}hello|] = () => 'Hello';|]
 
 // @Filename: /exporting.ts
-////export * as Leaf from './leafModule';
+////[|{| "id": "leafExportDecl" |}export * as [|{| "isWriteAccess": true, "isDefinition": true, "contextRangeId": "leafExportDecl" |}Leaf|] from './leafModule';|]
 
 // @Filename: /importing.ts
-//// import { Leaf } from './exporting';
-//// Leaf.[|hello|]()
+//// [|{| "id": "leafImportDecl" |}import { [|{| "isWriteAccess": true, "isDefinition": true, "contextRangeId": "leafImportDecl" |}Leaf|] } from './exporting';|]
+//// [|Leaf|].[|hello|]()
 
 verify.noErrors();
 const ranges = test.ranges();
-const [r0Def, r0, r1] = ranges;
-verify.singleReferenceGroup("const hello: () => string", [r0, r1]);
+const [helloDecl, helloDef, leafExportDecl, leafDef, leafImportDecl, leafImportDef, leafUse, helloUse] = ranges;
+verify.singleReferenceGroup("const hello: () => string", [helloDef, helloUse]);
+const leafExportAsRef = { definition: "import Leaf", ranges: [leafDef] };
+const leafImportRef = { definition: "import Leaf", ranges: [leafImportDef, leafUse] };
+verify.referenceGroups([leafDef], [leafExportAsRef, leafImportRef]);
+verify.referenceGroups([leafImportDef, leafUse], [leafImportRef, leafExportAsRef]);
diff --git a/tests/cases/fourslash/referencesForStatementKeywords.ts b/tests/cases/fourslash/referencesForStatementKeywords.ts
@@ -17,7 +17,7 @@
 ////
 ////// export ... from ...
 ////[|{| "id": "exportDecl1" |}[|export|] [|type|] * [|from|] "[|{| "isWriteAccess": false, "isDefinition": false, "contextRangeId": "exportDecl1" |}./g|]";|]
-////[|{| "id": "exportDecl2" |}[|export|] [|type|] [|{| "id": "exportDecl2_namespaceExport" |}* [|as|] [|{| "isWriteAccess": true, "isDefinition": true, "contextRangeId": "exportDecl2_namespaceExport" |}H|]|] [|from|] "[|{| "isWriteAccess": false, "isDefinition": false, "contextRangeId": "exportDecl2" |}./h|]";|]
+////[|{| "id": "exportDecl2" |}[|export|] [|type|] [|{| "id": "exportDecl2_namespaceExport" |}* [|as|] [|{| "isWriteAccess": true, "isDefinition": true, "contextRangeId": "exportDecl2" |}H|]|] [|from|] "[|{| "isWriteAccess": false, "isDefinition": false, "contextRangeId": "exportDecl2" |}./h|]";|]
 ////[|{| "id": "exportDecl3" |}[|export|] [|type|] { [|{| "isWriteAccess": true, "isDefinition": true, "contextRangeId": "exportDecl3" |}I|] } [|from|] "[|{| "isWriteAccess": false, "isDefinition": false, "contextRangeId": "exportDecl3" |}./i|]";|]
 ////[|{| "id": "exportDecl4" |}[|export|] [|type|] { j1, j2 [|as|] [|{| "isWriteAccess": true, "isDefinition": true, "contextRangeId": "exportDecl4" |}j3|] } [|from|] "[|{| "isWriteAccess": false, "isDefinition": false, "contextRangeId": "exportDecl4" |}./j|]";|]
 ////[|{| "id": "typeDecl1" |}type [|{| "isWriteAccess": true, "isDefinition": true, "contextRangeId": "typeDecl1" |}Z1|] = 1;|]

Original file line number	Diff line number	Diff line change
`@@ -481,6 +481,9 @@ namespace ts.FindAllReferences {`
`481`	`481`	`return exportInfo(symbol, getExportKindForDeclaration(exportNode));`
`482`	`482`	`}`
`483`	`483`	`}`
	`484`	`+ else if (isNamespaceExport(parent)) {`
	`485`	`+ return exportInfo(symbol, ExportKind.Named);`
	`486`	`+ }`
`484`	`487`	// If we are in `export = a;` or `export default a;`, `parent` is the export assignment.
`485`	`488`	`else if (isExportAssignment(parent)) {`
`486`	`489`	`return getExportAssignmentExport(parent);`