Fix tsconfig inheritance in gulpfile -- must do it manually

Andy Hanson · Andy Hanson · commit 757af2e1d6ae · 2017-01-12T13:11:26.000-08:00
diff --git a/Gulpfile.ts b/Gulpfile.ts
@@ -242,23 +242,21 @@ function needsUpdate(source: string | string[], dest: string | string[]): boolea
     return true;
 }
 
+// Doing tsconfig inheritance manually. https://github.com/ivogabe/gulp-typescript/issues/459
+const tsconfigBase = JSON.parse(fs.readFileSync("src/tsconfig-base.json", "utf-8")).compilerOptions;
+
 function getCompilerSettings(base: tsc.Settings, useBuiltCompiler?: boolean): tsc.Settings {
     const copy: tsc.Settings = {};
-    copy.noEmitOnError = true;
-    copy.noImplicitAny = true;
-    copy.noImplicitThis = true;
-    copy.pretty = true;
-    copy.types = [];
+    for (const key in tsconfigBase) {
+        copy[key] = tsconfigBase[key];
+    }
     for (const key in base) {
         copy[key] = base[key];
     }
     if (!useDebugMode) {
         if (copy.removeComments === undefined) copy.removeComments = true;
         copy.newLine = "lf";
     }
-    else {
-        copy.preserveConstEnums = true;
-    }
     if (useBuiltCompiler === true) {
         copy.typescript = require("./built/local/typescript.js");
     }
diff --git a/src/compiler/sys.ts b/src/compiler/sys.ts
@@ -18,7 +18,7 @@ namespace ts {
         getFileSize?(path: string): number;
         writeFile(path: string, data: string, writeByteOrderMark?: boolean): void;
         /**
-         * @pollingInterval - this parameter is used in polling-based watchers and ignored in watchers that 
+         * @pollingInterval - this parameter is used in polling-based watchers and ignored in watchers that
          * use native OS file watching
          */
         watchFile?(path: string, callback: FileWatcherCallback, pollingInterval?: number): FileWatcher;
diff --git a/src/tsconfig-base.json b/src/tsconfig-base.json
@@ -1,6 +1,6 @@
 {
     "compilerOptions": {
-        "lib": ["es5"],
+        "noEmitOnError": true,
         "noImplicitAny": true,
         "noImplicitThis": true,
         "noUnusedLocals": true,

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"compilerOptions": {`
`3`		`- "lib": ["es5"],`
	`3`	`+ "noEmitOnError": true,`
`4`	`4`	`"noImplicitAny": true,`
`5`	`5`	`"noImplicitThis": true,`
`6`	`6`	`"noUnusedLocals": true,`