Merge pull request microsoft#28405 from weswigham/no-summary-non-watch-zero-errors

DanielRosenwasser · web-flow · commit 514e8a129f77 · 2018-11-07T16:37:23.000-08:00
Do not output summary if theres nothing to report
diff --git a/src/compiler/watch.ts b/src/compiler/watch.ts
@@ -117,6 +117,7 @@ namespace ts {
     }
 
     export function getErrorSummaryText(errorCount: number, newLine: string) {
+        if (errorCount === 0) return "";
         const d = createCompilerDiagnostic(errorCount === 1 ? Diagnostics.Found_1_error : Diagnostics.Found_0_errors, errorCount);
         return `${newLine}${flattenDiagnosticMessageText(d.messageText, newLine)}${newLine}${newLine}`;
     }

Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,7 @@ namespace ts {`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`export function getErrorSummaryText(errorCount: number, newLine: string) {`
	`120`	`+ if (errorCount === 0) return "";`
`120`	`121`	`const d = createCompilerDiagnostic(errorCount === 1 ? Diagnostics.Found_1_error : Diagnostics.Found_0_errors, errorCount);`
`121`	`122`	return `${newLine}${flattenDiagnosticMessageText(d.messageText, newLine)}${newLine}${newLine}`;
`122`	`123`	`}`