code review comments

mhegazy · mhegazy · commit 41dbae58f342 · 2017-03-08T14:15:26.000-08:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -9598,7 +9598,7 @@ namespace ts {
                                 getInferenceMapper(context)));
                     }
                     else {
-                        inferredType = emptyObjectType;
+                        inferredType = context.useAnyForNoInferences ? anyType : emptyObjectType;
                     }
 
                     inferenceSucceeded = true;
@@ -9614,9 +9614,6 @@ namespace ts {
                             context.inferredTypes[index] = inferredType = instantiatedConstraint;
                         }
                     }
-                    if (context.useAnyForNoInferences && !inferences.length && inferredType === emptyObjectType) {
-                        context.inferredTypes[index] = inferredType = anyType;
-                    }
                 }
                 else if (context.failedTypeParameterIndex === undefined || context.failedTypeParameterIndex > index) {
                     // If inference failed, it is necessary to record the index of the failed type parameter (the one we are on).

Original file line number	Diff line number	Diff line change
`@@ -9598,7 +9598,7 @@ namespace ts {`
`9598`	`9598`	`getInferenceMapper(context)));`
`9599`	`9599`	`}`
`9600`	`9600`	`else {`
`9601`		`- inferredType = emptyObjectType;`
	`9601`	`+ inferredType = context.useAnyForNoInferences ? anyType : emptyObjectType;`
`9602`	`9602`	`}`
`9603`	`9603`
`9604`	`9604`	`inferenceSucceeded = true;`
`@@ -9614,9 +9614,6 @@ namespace ts {`
`9614`	`9614`	`context.inferredTypes[index] = inferredType = instantiatedConstraint;`
`9615`	`9615`	`}`
`9616`	`9616`	`}`
`9617`		`- if (context.useAnyForNoInferences && !inferences.length && inferredType === emptyObjectType) {`
`9618`		`- context.inferredTypes[index] = inferredType = anyType;`
`9619`		`- }`
`9620`	`9617`	`}`
`9621`	`9618`	`else if (context.failedTypeParameterIndex === undefined \|\| context.failedTypeParameterIndex > index) {`
`9622`	`9619`	`// If inference failed, it is necessary to record the index of the failed type parameter (the one we are on).`