forked from microsoft/winget-cli
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathARPChanges.cpp
More file actions
459 lines (370 loc) · 17.2 KB
/
Copy pathARPChanges.cpp
File metadata and controls
459 lines (370 loc) · 17.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
#include "pch.h"
#include "TestCommon.h"
#include "TestSource.h"
#include "TestHooks.h"
#include <Workflows/WorkflowBase.h>
#include <Workflows/InstallFlow.h>
#include <winget/Manifest.h>
#include <winget/ARPCorrelationAlgorithms.h>
#include <Microsoft/PredefinedInstalledSourceFactory.h>
#include <winget/PackageVersionSelection.h>
using namespace TestCommon;
using namespace AppInstaller;
using namespace AppInstaller::CLI;
using namespace AppInstaller::CLI::Execution;
using namespace AppInstaller::CLI::Workflow;
using namespace AppInstaller::Logging;
using namespace AppInstaller::Repository;
using namespace AppInstaller::Repository::Correlation;
struct TestTelemetry : public TelemetryTraceLogger
{
void LogSuccessfulInstallARPChange(
std::string_view sourceIdentifier,
std::string_view packageIdentifier,
std::string_view packageVersion,
std::string_view packageChannel,
size_t changesToARP,
size_t matchesInARP,
size_t countOfIntersectionOfChangesAndMatches,
std::string_view arpName,
std::string_view arpVersion,
std::string_view arpPublisher,
std::string_view arpLanguage) const noexcept override
{
WasLogSuccessfulInstallARPChangeCalled = true;
if (OnLogSuccessfulInstallARPChange)
{
OnLogSuccessfulInstallARPChange(
sourceIdentifier, packageIdentifier, packageVersion, packageChannel,
changesToARP, matchesInARP, countOfIntersectionOfChangesAndMatches,
arpName, arpVersion, arpPublisher, arpLanguage);
}
}
std::function<void(
std::string_view, std::string_view, std::string_view, std::string_view,
size_t, size_t, size_t,
std::string_view, std::string_view, std::string_view, std::string_view)> OnLogSuccessfulInstallARPChange;
mutable bool WasLogSuccessfulInstallARPChangeCalled = false;
};
struct ARPTestContext : public Context
{
ARPTestContext(Manifest::InstallerTypeEnum installerType = Manifest::InstallerTypeEnum::Exe) :
Context(OStream, IStream), SourceFactory([this](const SourceDetails&) { return Source; })
{
// Put installer in to control whether arp change code cares to run
Manifest::ManifestInstaller installer;
installer.BaseInstallerType = installerType;
Add<Data::Installer>(std::move(installer));
// Put in an empty manifest by default
Manifest::Manifest manifest;
manifest.Id = "Installing.Id";
manifest.Version = "Installing.Version";
manifest.Channel = "Installing.Channel";
manifest.DefaultLocalization.Add<Manifest::Localization::PackageName>("Installing.Name");
Add<Data::Manifest>(std::move(manifest));
// Set up logger to intercept event
Logger = std::make_shared<TestTelemetry>();
TestHook_SetTelemetryOverride(Logger);
Logger->OnLogSuccessfulInstallARPChange = [this](
std::string_view sourceIdentifier,
std::string_view packageIdentifier,
std::string_view packageVersion,
std::string_view packageChannel,
size_t changesToARP,
size_t matchesInARP,
size_t countOfIntersectionOfChangesAndMatches,
std::string_view arpName,
std::string_view arpVersion,
std::string_view arpPublisher,
std::string_view arpLanguage)
{
SourceIdentifier = sourceIdentifier;
PackageIdentifier = packageIdentifier;
PackageVersion = packageVersion;
PackageChannel = packageChannel;
ChangesToARP = changesToARP;
MatchesInARP = matchesInARP;
CountOfIntersectionOfChangesAndMatches = countOfIntersectionOfChangesAndMatches;
ARPName = arpName;
ARPVersion = arpVersion;
ARPPublisher = arpPublisher;
ARPLanguage = arpLanguage;
};
// Inject our source
TestHook_SetSourceFactoryOverride(std::string{ Repository::Microsoft::PredefinedInstalledSourceFactory::Type() }, SourceFactory);
Source = std::make_shared<TestSource>();
Source->SearchFunction = [&](const SearchRequest& request)
{
return request.IsForEverything() ? EverythingResult : MatchResult;
};
// The package version is used to get the source identifier
Add<Data::PackageVersion>(TestPackageVersion::Make(Get<Data::Manifest>(), Source));
// Populate everything result with a few items
AddEverythingResult("Id1", "Name1", "Publisher1", "1.0");
AddEverythingResult("Id2", "Name2", "Publisher2", "2.0");
}
~ARPTestContext()
{
TestHook_ClearSourceFactoryOverrides();
TestHook_SetTelemetryOverride({});
}
void AddEverythingResult(std::string_view id, std::string_view name, std::string_view publisher, std::string_view version)
{
AddResult(EverythingResult, id, name, publisher, version);
}
void AddMatchResult(std::string_view id, std::string_view name, std::string_view publisher, std::string_view version)
{
AddResult(MatchResult, id, name, publisher, version);
}
void ExpectEvent(size_t arpChanges, size_t matches, size_t overlap, const std::shared_ptr<ICompositePackage>& arpEntry = nullptr)
{
REQUIRE(Logger->WasLogSuccessfulInstallARPChangeCalled);
const auto& manifest = Get<Data::Manifest>();
REQUIRE(Source->GetIdentifier() == SourceIdentifier);
REQUIRE(manifest.Id == PackageIdentifier);
REQUIRE(manifest.Version == PackageVersion);
REQUIRE(manifest.Channel == PackageChannel);
REQUIRE(arpChanges == ChangesToARP);
REQUIRE(matches == MatchesInARP);
REQUIRE(overlap == CountOfIntersectionOfChangesAndMatches);
if (arpEntry)
{
auto version = GetInstalledVersion(arpEntry);
REQUIRE(version->GetProperty(PackageVersionProperty::Name) == ARPName);
REQUIRE(version->GetProperty(PackageVersionProperty::Version) == ARPVersion);
auto metadata = version->GetMetadata();
REQUIRE(metadata[PackageVersionMetadata::Publisher] == ARPPublisher);
REQUIRE(metadata[PackageVersionMetadata::InstalledLocale] == ARPLanguage);
}
else
{
REQUIRE(ARPName.empty());
REQUIRE(ARPVersion.empty());
REQUIRE(ARPPublisher.empty());
REQUIRE(ARPLanguage.empty());
}
}
std::ostringstream OStream;
std::istringstream IStream;
std::shared_ptr<TestTelemetry> Logger;
TestSourceFactory SourceFactory;
std::shared_ptr<TestSource> Source;
SearchResult EverythingResult;
SearchResult MatchResult;
// EventData
std::string SourceIdentifier;
std::string PackageIdentifier;
std::string PackageVersion;
std::string PackageChannel;
size_t ChangesToARP;
size_t MatchesInARP;
size_t CountOfIntersectionOfChangesAndMatches;
std::string ARPName;
std::string ARPVersion;
std::string ARPPublisher;
std::string ARPLanguage;
private:
void AddResult(SearchResult& result, std::string_view id, std::string_view name, std::string_view publisher, std::string_view version)
{
PackageMatchFilter defaultFilter{ PackageMatchField::Id, MatchType::Exact };
Manifest::Manifest manifest;
manifest.Id = id;
manifest.DefaultLocalization.Add<Manifest::Localization::PackageName>(name);
manifest.DefaultLocalization.Add<Manifest::Localization::Publisher>(publisher);
manifest.Version = version;
manifest.Installers.push_back({});
TestPackage::MetadataMap metadata;
metadata[PackageVersionMetadata::Publisher] = publisher;
result.Matches.emplace_back(TestCompositePackage::Make(manifest, std::move(metadata), std::vector<Manifest::Manifest>{}, Source), defaultFilter);
}
};
// Override the correlation heuristic by an empty one to ensure that these tests
// consider only the exact matching.
struct TestHeuristicOverride
{
TestHeuristicOverride()
{
IARPMatchConfidenceAlgorithm::OverrideInstance(&m_algorithm);
}
~TestHeuristicOverride()
{
IARPMatchConfidenceAlgorithm::ResetInstance();
}
private:
EmptyMatchConfidenceAlgorithm m_algorithm;
};
TEST_CASE("ARPChanges_MSIX_Ignored", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context(Manifest::InstallerTypeEnum::Msix);
context << SnapshotARPEntries;
REQUIRE(!context.Contains(Data::ARPCorrelationData));
context << ReportARPChanges;
REQUIRE(!context.Logger->WasLogSuccessfulInstallARPChangeCalled);
}
TEST_CASE("ARPChanges_CheckSnapshot", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context;
context << SnapshotARPEntries;
REQUIRE(context.Contains(Data::ARPCorrelationData));
auto snapshot = context.Get<Data::ARPCorrelationData>().GetPreInstallSnapshot();
REQUIRE(context.EverythingResult.Matches.size() == snapshot.size());
// Destructively match
for (const auto& match : context.EverythingResult.Matches)
{
bool found = false;
for (auto itr = snapshot.begin(); itr != snapshot.end(); ++itr)
{
if (match.Package->GetProperty(PackageProperty::Id) == std::get<0>(*itr))
{
REQUIRE(GetInstalledVersion(match.Package)->GetProperty(PackageVersionProperty::Version) == std::get<1>(*itr));
REQUIRE(GetInstalledVersion(match.Package)->GetProperty(PackageVersionProperty::Channel) == std::get<2>(*itr));
snapshot.erase(itr);
found = true;
break;
}
}
REQUIRE(found);
}
REQUIRE(snapshot.empty());
}
TEST_CASE("ARPChanges_NoChange_NoMatch", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context;
context << SnapshotARPEntries;
REQUIRE(context.Contains(Data::ARPCorrelationData));
context << ReportARPChanges;
context.ExpectEvent(0, 0, 0);
}
TEST_CASE("ARPChanges_NoChange_SingleMatch", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context;
context << SnapshotARPEntries;
REQUIRE(context.Contains(Data::ARPCorrelationData));
context.AddMatchResult("MatchId1", "MatchName1", "MatchPublisher1", "MatchVersion1");
context << ReportARPChanges;
context.ExpectEvent(0, 1, 0, context.MatchResult.Matches[0].Package);
}
TEST_CASE("ARPChanges_NoChange_MultiMatch", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context;
context << SnapshotARPEntries;
REQUIRE(context.Contains(Data::ARPCorrelationData));
context.AddMatchResult("MatchId1", "MatchName1", "MatchPublisher1", "MatchVersion1");
context.AddMatchResult("MatchId2", "MatchName2", "MatchPublisher2", "MatchVersion2");
context << ReportARPChanges;
context.ExpectEvent(0, 2, 0);
}
TEST_CASE("ARPChanges_SingleChange_NoMatch", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context;
context << SnapshotARPEntries;
REQUIRE(context.Contains(Data::ARPCorrelationData));
context.AddEverythingResult("EverythingId1", "EverythingName1", "EverythingPublisher1", "EverythingVersion1");
context << ReportARPChanges;
context.ExpectEvent(1, 0, 0);
}
TEST_CASE("ARPChanges_SingleChange_SingleMatch", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context;
context << SnapshotARPEntries;
REQUIRE(context.Contains(Data::ARPCorrelationData));
context.AddEverythingResult("EverythingId1", "EverythingName1", "EverythingPublisher1", "EverythingVersion1");
context.AddMatchResult("MatchId1", "MatchName1", "MatchPublisher1", "MatchVersion1");
context << ReportARPChanges;
context.ExpectEvent(1, 1, 0, context.MatchResult.Matches.back().Package);
}
TEST_CASE("ARPChanges_SingleChange_MultiMatch", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context;
context << SnapshotARPEntries;
REQUIRE(context.Contains(Data::ARPCorrelationData));
context.AddEverythingResult("EverythingId1", "EverythingName1", "EverythingPublisher1", "EverythingVersion1");
context.AddMatchResult("MatchId1", "MatchName1", "MatchPublisher1", "MatchVersion1");
context.MatchResult.Matches.emplace_back(context.EverythingResult.Matches.back());
context << ReportARPChanges;
context.ExpectEvent(1, 2, 1, context.EverythingResult.Matches.back().Package);
}
TEST_CASE("ARPChanges_MultiChange_NoMatch", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context;
context << SnapshotARPEntries;
REQUIRE(context.Contains(Data::ARPCorrelationData));
context.AddEverythingResult("EverythingId1", "EverythingName1", "EverythingPublisher1", "EverythingVersion1");
context.AddEverythingResult("EverythingId2", "EverythingName2", "EverythingPublisher2", "EverythingVersion2");
context << ReportARPChanges;
context.ExpectEvent(2, 0, 0);
}
TEST_CASE("ARPChanges_MultiChange_SingleMatch_NoOverlap", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context;
context << SnapshotARPEntries;
REQUIRE(context.Contains(Data::ARPCorrelationData));
context.AddEverythingResult("EverythingId1", "EverythingName1", "EverythingPublisher1", "EverythingVersion1");
context.AddEverythingResult("EverythingId2", "EverythingName2", "EverythingPublisher2", "EverythingVersion2");
context.AddMatchResult("MatchId1", "MatchName1", "MatchPublisher1", "MatchVersion1");
context << ReportARPChanges;
context.ExpectEvent(2, 1, 0, context.MatchResult.Matches.back().Package);
}
TEST_CASE("ARPChanges_MultiChange_SingleMatch_Overlap", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context;
context << SnapshotARPEntries;
REQUIRE(context.Contains(Data::ARPCorrelationData));
context.AddEverythingResult("EverythingId1", "EverythingName1", "EverythingPublisher1", "EverythingVersion1");
context.AddEverythingResult("EverythingId2", "EverythingName2", "EverythingPublisher2", "EverythingVersion2");
context.MatchResult.Matches.emplace_back(context.EverythingResult.Matches.back());
context << ReportARPChanges;
context.ExpectEvent(2, 1, 1, context.MatchResult.Matches.back().Package);
}
TEST_CASE("ARPChanges_MultiChange_MultiMatch_NoOverlap", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context;
context << SnapshotARPEntries;
REQUIRE(context.Contains(Data::ARPCorrelationData));
context.AddEverythingResult("EverythingId1", "EverythingName1", "EverythingPublisher1", "EverythingVersion1");
context.AddEverythingResult("EverythingId2", "EverythingName2", "EverythingPublisher2", "EverythingVersion2");
context.AddMatchResult("MatchId1", "MatchName1", "MatchPublisher1", "MatchVersion1");
context.AddMatchResult("MatchId2", "MatchName2", "MatchPublisher2", "MatchVersion2");
context << ReportARPChanges;
context.ExpectEvent(2, 2, 0);
}
TEST_CASE("ARPChanges_MultiChange_MultiMatch_SingleOverlap", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context;
context << SnapshotARPEntries;
REQUIRE(context.Contains(Data::ARPCorrelationData));
context.AddEverythingResult("EverythingId1", "EverythingName1", "EverythingPublisher1", "EverythingVersion1");
context.AddEverythingResult("EverythingId2", "EverythingName2", "EverythingPublisher2", "EverythingVersion2");
context.AddMatchResult("MatchId1", "MatchName1", "MatchPublisher1", "MatchVersion1");
context.MatchResult.Matches.emplace_back(context.EverythingResult.Matches.back());
context << ReportARPChanges;
context.ExpectEvent(2, 2, 1, context.MatchResult.Matches.back().Package);
}
TEST_CASE("ARPChanges_MultiChange_MultiMatch_MultiOverlap", "[ARPChanges][workflow]")
{
TestHeuristicOverride heuristicOverride;
ARPTestContext context;
context << SnapshotARPEntries;
REQUIRE(context.Contains(Data::ARPCorrelationData));
context.AddEverythingResult("EverythingId1", "EverythingName1", "EverythingPublisher1", "EverythingVersion1");
context.MatchResult.Matches.emplace_back(context.EverythingResult.Matches.back());
context.AddEverythingResult("EverythingId2", "EverythingName2", "EverythingPublisher2", "EverythingVersion2");
context.MatchResult.Matches.emplace_back(context.EverythingResult.Matches.back());
context << ReportARPChanges;
context.ExpectEvent(2, 2, 2);
}