[agent_docker] appropriate selinux labelling#1115
Open
anthonygego wants to merge 1 commit into
Open
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 medium |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems our README has mentioned the code works with SELinux for 11 years without being the case.
This patch enables SELinux labelling on the mounted volumes. Since a temporary folder is created for each submission, I decided to apply a strict labelling (
Z) and associates two random MCS categories (as the container runtime does by default) to all containers with the same parent (of the same submission). This allows to share the Unix socket created in the parent container with the student containers.This last operation is done by using the parent sockets path as the seed for the random function to avoid keeping more state in memory and a more important refactor.
This is probably not perfect, but still better than deactivating SELinux to allow the system to work.
This patch was tested on a system with SELinux disabled at boot time and the options seem to be ignored, so it should be the case on distros that are not shipped with SELinux without further checks.