refactor: BubbleSortRecursion: improving naming, adding standard test (TheAlgorithms#5267)

alxkm · Alex Klymenko · vil02 · web-flow · commit 208e1e99f0ce · 2024-06-30T17:51:11.000Z
* refactor: improving naming, adding standard test

* style: remove `BubbleSortRecursive` from pmd exclude list

* docs: typo fix

---------

Co-authored-by: Alex Klymenko &lt;alx@alx.com&gt;
Co-authored-by: Piotr Idzik &lt;65706193+vil02@users.noreply.github.com&gt;
diff --git a/DIRECTORY.md b/DIRECTORY.md
@@ -490,7 +490,7 @@
             * [BitonicSort](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/sorts/BitonicSort.java)
             * [BogoSort](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/sorts/BogoSort.java)
             * [BubbleSort](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/sorts/BubbleSort.java)
-            * [BubbleSortRecursion](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/sorts/BubbleSortRecursion.java)
+            * [BubbleSortRecursive](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/sorts/BubbleSortRecursive.java)
             * [BucketSort](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/sorts/BucketSort.java)
             * [CircleSort](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/sorts/CircleSort.java)
             * [CocktailShakerSort](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/sorts/CocktailShakerSort.java)
@@ -859,6 +859,7 @@
             * [BinaryInsertionSortTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/sorts/BinaryInsertionSortTest.java)
             * [BogoSortTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/sorts/BogoSortTest.java)
             * [BubbleSortTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/sorts/BubbleSortTest.java)
+            * [BubbleSortRecursiveTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/sorts/BubbleSortRecursiveTest.java)
             * [BucketSortTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/sorts/BucketSortTest.java)
             * [CircleSortTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/sorts/CircleSortTest.java)
             * [CocktailShakerSortTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/sorts/CocktailShakerSortTest.java)
diff --git a/pmd-exclude.properties b/pmd-exclude.properties
@@ -76,7 +76,6 @@ com.thealgorithms.searches.InterpolationSearch=UselessParentheses
 com.thealgorithms.searches.KMPSearch=UselessParentheses
 com.thealgorithms.searches.LinearSearchThread=EmptyCatchBlock
 com.thealgorithms.searches.RabinKarpAlgorithm=UselessParentheses
-com.thealgorithms.sorts.BubbleSortRecursion=UselessParentheses
 com.thealgorithms.sorts.CircleSort=EmptyControlStatement
 com.thealgorithms.sorts.CombSort=UselessParentheses
 com.thealgorithms.sorts.DutchNationalFlagSort=UselessParentheses
diff --git a/src/main/java/com/thealgorithms/sorts/BubbleSortRecursion.java b/src/main/java/com/thealgorithms/sorts/BubbleSortRecursion.java
diff --git a/src/main/java/com/thealgorithms/sorts/BubbleSortRecursive.java b/src/main/java/com/thealgorithms/sorts/BubbleSortRecursive.java
@@ -0,0 +1,35 @@
+package com.thealgorithms.sorts;
+
+/**
+ * BubbleSort algorithm implemented using recursion
+ */
+public class BubbleSortRecursive implements SortAlgorithm {
+    /**
+     * @param array - an array should be sorted
+     * @return sorted array
+     */
+    @Override
+    public <T extends Comparable<T>> T[] sort(T[] array) {
+        bubbleSort(array, array.length);
+        return array;
+    }
+
+    /**
+     * BubbleSort algorithm implements using recursion
+     *
+     * @param array array contains elements
+     * @param len length of given array
+     */
+    private static <T extends Comparable<T>> void bubbleSort(T[] array, int len) {
+        boolean swapped = false;
+        for (int i = 0; i < len - 1; ++i) {
+            if (SortUtils.greater(array[i], array[i + 1])) {
+                SortUtils.swap(array, i, i + 1);
+                swapped = true;
+            }
+        }
+        if (swapped) {
+            bubbleSort(array, len - 1);
+        }
+    }
+}
diff --git a/src/test/java/com/thealgorithms/sorts/BubbleSortRecursiveTest.java b/src/test/java/com/thealgorithms/sorts/BubbleSortRecursiveTest.java
@@ -0,0 +1,8 @@
+package com.thealgorithms.sorts;
+
+public class BubbleSortRecursiveTest extends SortingAlgorithmTest {
+    @Override
+    SortAlgorithm getSortAlgorithm() {
+        return new BubbleSortRecursive();
+    }
+}
