Use pre-increment for iterators

mscdex · mscdex · commit b64f8ba7acb7 · 2013-08-24T14:02:37.000-04:00
Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
diff --git a/src/javaObject.cpp b/src/javaObject.cpp
@@ -43,7 +43,7 @@
     javaReflectionGetMethods(env, objClazz, &methods, false);
     jclass methodClazz = env->FindClass("java/lang/reflect/Method");
     jmethodID method_getName = env->GetMethodID(methodClazz, "getName", "()Ljava/lang/String;");
-    for(std::list<jobject>::iterator it = methods.begin(); it != methods.end(); it++) {
+    for(std::list<jobject>::iterator it = methods.begin(); it != methods.end(); ++it) {
       jstring methodNameJava = (jstring)env->CallObjectMethod(*it, method_getName);
       std::string methodNameStr = javaToString(env, methodNameJava);
 
@@ -60,7 +60,7 @@
     javaReflectionGetFields(env, objClazz, &fields);
     jclass fieldClazz = env->FindClass("java/lang/reflect/Field");
     jmethodID field_getName = env->GetMethodID(fieldClazz, "getName", "()Ljava/lang/String;");
-    for(std::list<jobject>::iterator it = fields.begin(); it != fields.end(); it++) {
+    for(std::list<jobject>::iterator it = fields.begin(); it != fields.end(); ++it) {
       jstring fieldNameJava = (jstring)env->CallObjectMethod(*it, field_getName);
       std::string fieldNameStr = javaToString(env, fieldNameJava);
 
diff --git a/src/utils.cpp b/src/utils.cpp
@@ -665,7 +665,7 @@ std::string methodNotFoundToString(JNIEnv *env, jclass clazz, std::string method
   }
 
   int count = 0;
-  for(std::list<jobject>::iterator it = methods.begin(); it != methods.end(); it++) {
+  for(std::list<jobject>::iterator it = methods.begin(); it != methods.end(); ++it) {
     jstring methodNameTestJava = (jstring)env->CallObjectMethod(*it, member_getName);
     std::string methodNameTest = javaToString(env, methodNameTestJava);
     if(methodNameTest == methodName) {

Original file line number	Diff line number	Diff line change
`@@ -665,7 +665,7 @@ std::string methodNotFoundToString(JNIEnv *env, jclass clazz, std::string method`
`665`	`665`	`}`
`666`	`666`
`667`	`667`	`int count = 0;`
`668`		`- for(std::list<jobject>::iterator it = methods.begin(); it != methods.end(); it++) {`
	`668`	`+ for(std::list<jobject>::iterator it = methods.begin(); it != methods.end(); ++it) {`
`669`	`669`	`jstring methodNameTestJava = (jstring)env->CallObjectMethod(*it, member_getName);`
`670`	`670`	`std::string methodNameTest = javaToString(env, methodNameTestJava);`
`671`	`671`	`if(methodNameTest == methodName) {`