-
Notifications
You must be signed in to change notification settings - Fork 3k
Comparing changes
Open a pull request
base repository: nltk/nltk
base: develop
head repository: ExplodingCabbage/nltk
compare: develop
- 17 commits
- 2 files changed
- 1 contributor
Commits on Jan 9, 2016
-
Configuration menu - View commit details
-
Copy full SHA for e89631a - Browse repository at this point
Copy the full SHA e89631aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3af726f - Browse repository at this point
Copy the full SHA 3af726fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d72aa4 - Browse repository at this point
Copy the full SHA 9d72aa4View commit details
Commits on Jan 10, 2016
-
[PorterStemmer] Remove stem_word from PorterStemmer. Breaks backwards…
… compatability! Prior to this change, the public API of the PorterStemmer was a mess. NLTK's version was based off Vivake Gupta's implementation at http://tartarus.org/~martin/PorterStemmer/python.txt, endorsed by Martin himself at http://tartarus.org/~martin/PorterStemmer/. However, Gupta's implementation is a shoddy port of Martin Porter's own implementation in C, and had several vestigial quirks lying around. These include the claim that the stem() method takes a "char pointer" as an argument (no such thing in Python) and the need to pass in start and end indexes between which stem() should read the word from the given char array. At some point in nltk's history, during or prior to the 2006 commit that added porter.py to the current Git repository: edf4677 this was "solved" by renaming Vivake's stem() method to stem_word() and creating a wrapper for it called stem() that conformed to the StemmerI interface. This was completely pointless; the right thing to do would've been to remove the unnecessary parts of Vivake's stem() method and thereby acheive conformity to StemmerI. This commit does this, but at the cost of breaking backwards compatibility for anyone who was using stem_word(word) instead of stem(word); those people will need to adjust their application code when updating to the latest version of NLTK.
Configuration menu - View commit details
-
Copy full SHA for 2000554 - Browse repository at this point
Copy the full SHA 2000554View commit details -
[PorterStemmer] Remove more commented out code.
I don't even know where this came from. It's not part of the Vivake Gupta version at http://tartarus.org/~martin/PorterStemmer/python.txt Regardless, there's no reason for it to remain here.
Configuration menu - View commit details
-
Copy full SHA for 8b7ffe6 - Browse repository at this point
Copy the full SHA 8b7ffe6View commit details -
[PorterStemmer] Remove _adjust_case for consistency with Lancaster an…
…d Snowball Handling of upper and lower case is not specified in Martin Porter's "An algorithm for suffix stripping" paper; the algorithm description there never even mentions the existence of difference letter cases. Nor does Martin's C implementation of the stemmer at: http://tartarus.org/~martin/PorterStemmer/c.txt handle case in the way that NLTK's version has been doing; instead, it simply requires that the user convert their word to lowercase before calling stem(). Since there is no Porter-specific reason to preserve our (odd) behaviour here, and our other StemmerI implementations don't do it, we should probably purge it, as this commit does.
Configuration menu - View commit details
-
Copy full SHA for a2d1dfa - Browse repository at this point
Copy the full SHA a2d1dfaView commit details -
[PorterStemmer] Reimplement steps 1a and 1b while:
- Making the code more readable and including quotes in comments that allow the code to be matched up with Porter's published algorithm - Marking NLTK-specific departure points properly
Configuration menu - View commit details
-
Copy full SHA for 829b29a - Browse repository at this point
Copy the full SHA 829b29aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 221c193 - Browse repository at this point
Copy the full SHA 221c193View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccd5525 - Browse repository at this point
Copy the full SHA ccd5525View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10498f8 - Browse repository at this point
Copy the full SHA 10498f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92d845f - Browse repository at this point
Copy the full SHA 92d845fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ad2b28 - Browse repository at this point
Copy the full SHA 9ad2b28View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb160de - Browse repository at this point
Copy the full SHA cb160deView commit details -
Configuration menu - View commit details
-
Copy full SHA for fab16ba - Browse repository at this point
Copy the full SHA fab16baView commit details -
Configuration menu - View commit details
-
Copy full SHA for dccf396 - Browse repository at this point
Copy the full SHA dccf396View commit details
Commits on Jan 11, 2016
-
[PorterStemmer] Create 'modes' to let users use a faithful version of…
… the algorithm. Also sort out the docs.
Configuration menu - View commit details
-
Copy full SHA for e7ec0ba - Browse repository at this point
Copy the full SHA e7ec0baView commit details -
[PorterStemmer] Mention the contributions of people whose work we've …
…used in the AUTHORS file
Configuration menu - View commit details
-
Copy full SHA for 0cc39c6 - Browse repository at this point
Copy the full SHA 0cc39c6View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff develop...develop