OAuth1.0: send "oob" instead of null callback while requesting RequestToken (thanks to https://github.com/Rafaelsk)

kullfar · kullfar · commit 03dd1eafd8bc · 2018-04-18T13:55:23.000+03:00
diff --git a/changelog b/changelog
@@ -4,6 +4,7 @@
  * add new API - Automatic (https://www.automatic.com/) (thanks to https://github.com/ramsrib)
  * add new API - Fitbit (https://www.fitbit.com/) (thanks to https://github.com/JustinLawler and https://github.com/alexthered)
  * deprecate OAuthConfig
+ * OAuth1.0: send "oob" instead of null callback while requesting RequestToken (thanks to https://github.com/Rafaelsk)
 
 [5.3.0]
  * fix Salesforce API (thanks to https://github.com/jhorowitz-firedrum)
diff --git a/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuth10aService.java b/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuth10aService.java
@@ -78,7 +78,10 @@ public OAuth1RequestToken convert(Response response) throws IOException {
 
     protected OAuthRequest prepareRequestTokenRequest() {
         final OAuthRequest request = new OAuthRequest(api.getRequestTokenVerb(), api.getRequestTokenEndpoint());
-        final String callback = getCallback();
+        String callback = getCallback();
+        if (callback == null) {
+            callback = OAuthConstants.OOB;
+        }
         log("setting oauth_callback to " + callback);
         request.addOAuthParameter(OAuthConstants.CALLBACK, callback);
         addOAuthParams(request, "");
