Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: AdvancedClimateSystems/uModbus
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: rm-outdated-script
Choose a base ref
...
head repository: AdvancedClimateSystems/uModbus
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 14 commits
  • 14 files changed
  • 6 contributors

Commits on Jun 11, 2019

  1. Merge pull request #72 from AdvancedClimateSystems/rm-outdated-script

    Remove outdated script simple_rtu_data_store.py
    jaapz authored Jun 11, 2019
    Configuration menu
    Copy the full SHA
    d173ab5 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. Update dev builds

    The dev depedencies have been updated to a recent version.
    
    Support for Python 3.3 has been removed.  Python 3.3 is depricated as of
    2017-09-29. Travis doesn't support Python 3.3 builds anymore.
    
    On the other side, support for Python 3.7 and Python 3.8 have been
    added.
    OrangeTux authored Dec 4, 2019
    Configuration menu
    Copy the full SHA
    9951378 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bfd074d View commit details
    Browse the repository at this point in the history
  3. Bump to 1.0.3

    OrangeTux committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    749d69f View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2020

  1. Fix 2 error codes

    The error codes where off by 1.
    
    Fixes: #90
    OrangeTux committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    5fdc3b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Merge pull request #94 from AdvancedClimateSystems/fix-error-code

    Fix 2 error codes
    jaapz authored Jun 23, 2020
    Configuration menu
    Copy the full SHA
    dcf35a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2020

  1. Configuration menu
    Copy the full SHA
    0faaf90 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Configuration menu
    Copy the full SHA
    f3b438d View commit details
    Browse the repository at this point in the history
  2. Change factory methods to class methods (#103)

    Instead of declaring the create_from_request_pdu and create_from_response_pdu factory methods as @staticmethod, use @classmethod. Then the class is passed to the method as the cls parameter, which can be used to instantiate an instance, rather than hardcoding the class name.
    
    This allows the function classes to be subclassed without having to reimplement the factory methods just to change the class name.
    
    Also fixes up some comments that were incorrect.
    rgov authored Jul 27, 2020
    Configuration menu
    Copy the full SHA
    f125365 View commit details
    Browse the repository at this point in the history
  3. Remove redundant exception traceback (#102)

    `log.exception` already includes a traceback, so don't add another.
    rgov authored Jul 27, 2020
    Configuration menu
    Copy the full SHA
    82f0872 View commit details
    Browse the repository at this point in the history
  4. Allow omitted rule constraints to match any value (#101)

    The definition of umodbus.server.route gives default values of None to the arguments, suggesting they can be omitted. However, if you actually provide None, it will fail later when evaluating DataRule.match.
    
    This change makes it possible to omit any rule constraint to match on any value.
    rgov authored Jul 27, 2020
    Configuration menu
    Copy the full SHA
    63c7679 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Fix byte count when for WriteMultipleCoils (#105)

    For full bytes, the Byte Count field was calculated too high:
        8 // 8 + 1 = 2
    while only one byte is needed to represent 8 coils.
    
    Offset the values length before the truncating division to correctly
    round to whole bytes.  This is easier than what the standard
    formulates:
        N = Quantity of Outputs / 8, if the
        remainder is different of 0 ==> N = N+1
    
    Note that the actual data bytes were already handled with the correct
    length.  So in case of 8 coils, uModbus would send a Byte Count of 2,
    but only one data byte before the checksum.
    acolomb authored Aug 27, 2020
    Configuration menu
    Copy the full SHA
    b928ff4 View commit details
    Browse the repository at this point in the history
  2. Bump to 1.0.4

    OrangeTux committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    4fd98ba View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. Use non privileged tcp port in examples (#109)

    The server example had port 502 hard coded. This port is a privileged port.
    Trying to use it without permissions could result in a failure of the example.
    Port 502 is still the default, but a nice error message is printed to warn the user
    about the problem. Also a flag has been introduced to change the port.
    
    To keep the example client working with the example server code a similar
    change has been made to the example client.
    tiagocoutinho authored Nov 11, 2020
    Configuration menu
    Copy the full SHA
    f1128a7 View commit details
    Browse the repository at this point in the history
Loading