-
Notifications
You must be signed in to change notification settings - Fork 88
Comparing changes
Open a pull request
base repository: AdvancedClimateSystems/uModbus
base: rm-outdated-script
head repository: AdvancedClimateSystems/uModbus
compare: master
- 14 commits
- 14 files changed
- 6 contributors
Commits on Jun 11, 2019
-
Merge pull request #72 from AdvancedClimateSystems/rm-outdated-script
Remove outdated script simple_rtu_data_store.py
Configuration menu - View commit details
-
Copy full SHA for d173ab5 - Browse repository at this point
Copy the full SHA d173ab5View commit details
Commits on Dec 4, 2019
-
The dev depedencies have been updated to a recent version. Support for Python 3.3 has been removed. Python 3.3 is depricated as of 2017-09-29. Travis doesn't support Python 3.3 builds anymore. On the other side, support for Python 3.7 and Python 3.8 have been added.
Configuration menu - View commit details
-
Copy full SHA for 9951378 - Browse repository at this point
Copy the full SHA 9951378View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfd074d - Browse repository at this point
Copy the full SHA bfd074dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 749d69f - Browse repository at this point
Copy the full SHA 749d69fView commit details
Commits on Jun 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5fdc3b8 - Browse repository at this point
Copy the full SHA 5fdc3b8View commit details
Commits on Jun 23, 2020
-
Merge pull request #94 from AdvancedClimateSystems/fix-error-code
Fix 2 error codes
Configuration menu - View commit details
-
Copy full SHA for dcf35a1 - Browse repository at this point
Copy the full SHA dcf35a1View commit details
Commits on Jul 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0faaf90 - Browse repository at this point
Copy the full SHA 0faaf90View commit details
Commits on Jul 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f3b438d - Browse repository at this point
Copy the full SHA f3b438dView commit details -
Change factory methods to class methods (#103)
Instead of declaring the create_from_request_pdu and create_from_response_pdu factory methods as @staticmethod, use @classmethod. Then the class is passed to the method as the cls parameter, which can be used to instantiate an instance, rather than hardcoding the class name. This allows the function classes to be subclassed without having to reimplement the factory methods just to change the class name. Also fixes up some comments that were incorrect.
Configuration menu - View commit details
-
Copy full SHA for f125365 - Browse repository at this point
Copy the full SHA f125365View commit details -
Remove redundant exception traceback (#102)
`log.exception` already includes a traceback, so don't add another.
Configuration menu - View commit details
-
Copy full SHA for 82f0872 - Browse repository at this point
Copy the full SHA 82f0872View commit details -
Allow omitted rule constraints to match any value (#101)
The definition of umodbus.server.route gives default values of None to the arguments, suggesting they can be omitted. However, if you actually provide None, it will fail later when evaluating DataRule.match. This change makes it possible to omit any rule constraint to match on any value.
Configuration menu - View commit details
-
Copy full SHA for 63c7679 - Browse repository at this point
Copy the full SHA 63c7679View commit details
Commits on Aug 27, 2020
-
Fix byte count when for WriteMultipleCoils (#105)
For full bytes, the Byte Count field was calculated too high: 8 // 8 + 1 = 2 while only one byte is needed to represent 8 coils. Offset the values length before the truncating division to correctly round to whole bytes. This is easier than what the standard formulates: N = Quantity of Outputs / 8, if the remainder is different of 0 ==> N = N+1 Note that the actual data bytes were already handled with the correct length. So in case of 8 coils, uModbus would send a Byte Count of 2, but only one data byte before the checksum.Configuration menu - View commit details
-
Copy full SHA for b928ff4 - Browse repository at this point
Copy the full SHA b928ff4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fd98ba - Browse repository at this point
Copy the full SHA 4fd98baView commit details
Commits on Nov 11, 2020
-
Use non privileged tcp port in examples (#109)
The server example had port 502 hard coded. This port is a privileged port. Trying to use it without permissions could result in a failure of the example. Port 502 is still the default, but a nice error message is printed to warn the user about the problem. Also a flag has been introduced to change the port. To keep the example client working with the example server code a similar change has been made to the example client.
Configuration menu - View commit details
-
Copy full SHA for f1128a7 - Browse repository at this point
Copy the full SHA f1128a7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff rm-outdated-script...master