Bug: fix naming, order and formatting for diagnostics - #1637
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1637 +/- ##
==========================================
+ Coverage 71.30% 71.32% +0.02%
==========================================
Files 295 295
Lines 61195 61205 +10
==========================================
+ Hits 43637 43657 +20
+ Misses 17558 17548 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@Wraith2 Running tests now |
|
@Wraith2 Works great! No exceptions after over 500k requests. |
This was referenced Jun 5, 2022
|
Over 5 million requests now without exceptions |
DavoudEshtehari
approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1634
We were not being consistent about calling diagnostic message output functions before we set the result/exception/cancel methods on the TaskCompletionSource that the users is waiting on. This allowed a rare race condition to occur in libraries consuming diagnostic events and attempting to correlate it to their own current context.
This PR does 3 things:
s_diagnosticListenernot_diagnosticListenerN.B. netfx does not use diagnostics so no changes are required for that part of the project.
/cc @okolvik-avento if possible you could try the output artifacts nuget package once the CI run has completed?