Add jsxPragmaFrag support to typescript transform#11950
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Oct 14, 2020
Merged
Add jsxPragmaFrag support to typescript transform#11950nicolo-ribaudo merged 1 commit intobabel:mainfrom
jsxPragmaFrag support to typescript transform#11950nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2ec058d:
|
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27256/ |
JLHwung
commented
Aug 11, 2020
| api, | ||
| { | ||
| jsxPragma = "React", | ||
| jsxPragma = "React.createElement", |
Contributor
Author
There was a problem hiding this comment.
This change is invisible to users since (jsxPragmaFrag).split(".")[0] still returns React. It is meant to align with
7e29bc1 to
2ec058d
Compare
existentialism
approved these changes
Aug 25, 2020
Contributor
|
Hi! Is there a blocker for merge or is this ready to go? |
1 task
kaicataldo
approved these changes
Sep 17, 2020
jsxPragmaFrag support to typescript transform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
jsxPragmaFragso thatpreset-typescriptdoes not elide Fragment imports likeimport { Fragment } from "preact".Prior work: #9317, unfortunately that PR was abandoned due to lack of upstream support at that time. /cc @Tarnadas, the author of #9317.