forked from posit-dev/ggsql
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathsqlite.rs
More file actions
1668 lines (1443 loc) · 55.5 KB
/
Copy pathsqlite.rs
File metadata and controls
1668 lines (1443 loc) · 55.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
//! SQLite data source implementation
//!
//! Provides a reader for SQLite databases with Arrow DataFrame integration.
//! Works on both native targets and wasm32-unknown-unknown (via sqlite-wasm-rs).
use crate::reader::Reader;
use crate::{naming, DataFrame, GgsqlError, Result};
use arrow::array::*;
use arrow::datatypes::{DataType, TimeUnit};
use chrono::Datelike;
use rusqlite::Connection;
use std::cell::RefCell;
use std::collections::HashSet;
use std::sync::Arc;
/// SQLite SQL dialect.
///
/// Overrides type name methods for SQLite's limited type system
/// (TEXT for dates, REAL for numbers, INTEGER for booleans).
pub struct SqliteDialect;
impl super::SqlDialect for SqliteDialect {
fn string_type_name(&self) -> Option<&str> {
Some("TEXT")
}
fn number_type_name(&self) -> Option<&str> {
Some("REAL")
}
fn integer_type_name(&self) -> Option<&str> {
Some("INTEGER")
}
fn boolean_type_name(&self) -> Option<&str> {
Some("INTEGER")
}
fn date_type_name(&self) -> Option<&str> {
Some("TEXT")
}
fn datetime_type_name(&self) -> Option<&str> {
Some("TEXT")
}
fn time_type_name(&self) -> Option<&str> {
Some("TEXT")
}
fn sql_date_literal(&self, days_since_epoch: i32) -> String {
format!("date('1970-01-01', '+{} days')", days_since_epoch)
}
fn sql_datetime_literal(&self, microseconds_since_epoch: i64) -> String {
let seconds = microseconds_since_epoch as f64 / 1_000_000.0;
format!("datetime('1970-01-01 00:00:00', '+{} seconds')", seconds)
}
fn sql_time_literal(&self, nanoseconds_since_midnight: i64) -> String {
let seconds = nanoseconds_since_midnight as f64 / 1_000_000_000.0;
format!("time('00:00:00', '+{} seconds')", seconds)
}
fn sql_boolean_literal(&self, value: bool) -> String {
if value {
"1".to_string()
} else {
"0".to_string()
}
}
fn sql_spatial_setup(&self) -> Vec<String> {
vec![
"SELECT load_extension('mod_spatialite')".into(),
"SELECT CASE WHEN NOT EXISTS(SELECT 1 FROM sqlite_master WHERE name='spatial_ref_sys') \
THEN InitSpatialMetaData(1) END"
.into(),
]
}
fn sql_st_transform(&self, column: &str, source_crs: &str, target_crs: &str) -> String {
let source_srid = super::extract_epsg_srid(source_crs);
let target_srid = super::extract_epsg_srid(target_crs);
match (source_srid, target_srid) {
(Some(src), Some(tgt)) => {
format!("ST_Transform(SetSRID({}, {}), {})", column, src, tgt)
}
_ => {
let source_proj = source_crs.replace('\'', "''");
let target_proj = target_crs.replace('\'', "''");
let input = match source_srid {
Some(srid) => format!("SetSRID({}, {})", column, srid),
None => column.to_string(),
};
format!(
"ST_Transform({}, 0, NULL, '{}', '{}')",
input, source_proj, target_proj
)
}
}
}
fn sql_make_envelope(&self, xmin: f64, ymin: f64, xmax: f64, ymax: f64) -> String {
format!("BuildMbr({xmin}, {ymin}, {xmax}, {ymax})")
}
fn sql_ensure_geometry(&self, column: &str) -> String {
format!("COALESCE(GeomFromWKB({column}, 4326), {column})")
}
fn sql_geometry_bbox(&self, column: &str, from: &str) -> String {
format!(
"SELECT MIN(MbrMinX({column})) AS xmin, MIN(MbrMinY({column})) AS ymin, \
MAX(MbrMaxX({column})) AS xmax, MAX(MbrMaxY({column})) AS ymax \
FROM {from}"
)
}
/// Stock SQLite has no `STDDEV_POP` / `VAR_POP`, so express variance,
/// standard deviation, and standard error in portable arithmetic. Every
/// other aggregate falls through to the shared default.
fn sql_aggregate(&self, name: &str, qcol: &str) -> Option<String> {
// Population variance with a `MAX(0, …)` floor against tiny negative
// floats from catastrophic cancellation. Both `MAX(a, b)` and `SQRT`
// are scalar functions in modern bundled SQLite (math-functions build).
let var_pop = || format!("MAX(0.0, AVG({c} * {c}) - AVG({c}) * AVG({c}))", c = qcol);
let s = match name {
"var" => var_pop(),
"sdev" => format!("SQRT({})", var_pop()),
"se" => format!("(SQRT({}) / SQRT(COUNT({c})))", var_pop(), c = qcol),
_ => return super::default_sql_aggregate(name, qcol),
};
Some(s)
}
}
/// SQLite database reader
///
/// Executes SQL queries against SQLite databases (in-memory or file-based)
/// and returns results as DataFrames.
pub struct SqliteReader {
conn: Connection,
registered_tables: RefCell<HashSet<String>>,
}
impl SqliteReader {
/// Create a new in-memory SQLite reader
pub fn new() -> Result<Self> {
let conn = Connection::open_in_memory().map_err(|e| {
GgsqlError::ReaderError(format!("Failed to open in-memory SQLite: {}", e))
})?;
#[cfg(feature = "spatial")]
unsafe {
let _ = conn.load_extension_enable();
}
Ok(Self {
conn,
registered_tables: RefCell::new(HashSet::new()),
})
}
/// Create a SQLite reader from a connection string
pub fn from_connection_string(uri: &str) -> Result<Self> {
let conn_info = super::connection::parse_connection_string(uri)?;
let conn = match conn_info {
super::connection::ConnectionInfo::SQLite(path) => {
Connection::open(&path).map_err(|e| {
GgsqlError::ReaderError(format!("Failed to open SQLite file '{}': {}", path, e))
})?
}
_ => {
return Err(GgsqlError::ReaderError(format!(
"Connection string '{}' is not supported by SqliteReader",
uri
)))
}
};
#[cfg(feature = "spatial")]
unsafe {
let _ = conn.load_extension_enable();
}
Ok(Self {
conn,
registered_tables: RefCell::new(HashSet::new()),
})
}
/// Get a reference to the underlying SQLite connection
pub fn connection(&self) -> &Connection {
&self.conn
}
/// List table names known to this reader.
///
/// When `internal` is false, filters out internal tables (prefixed with `__ggsql_`).
pub fn list_tables(&self, internal: bool) -> Vec<String> {
self.registered_tables
.borrow()
.iter()
.filter(|name| internal || !name.starts_with("__ggsql_"))
.cloned()
.collect()
}
/// Check if a table is registered
fn table_exists(&self, name: &str) -> bool {
let sql = "SELECT 1 FROM sqlite_master WHERE type='table' AND name=?1";
self.conn
.prepare(sql)
.and_then(|mut stmt| stmt.exists([name]))
.unwrap_or(false)
}
}
impl Default for SqliteReader {
fn default() -> Self {
Self::new().expect("Failed to create default SqliteReader")
}
}
/// Map an Arrow DataType to a SQLite column type string
fn arrow_type_to_sqlite(dtype: &DataType) -> &'static str {
match dtype {
DataType::Float32 | DataType::Float64 => "REAL",
DataType::Int8
| DataType::Int16
| DataType::Int32
| DataType::Int64
| DataType::UInt8
| DataType::UInt16
| DataType::UInt32
| DataType::UInt64 => "INTEGER",
DataType::Boolean => "INTEGER",
DataType::Date32 => "TEXT",
DataType::Timestamp(_, _) => "TEXT",
DataType::Time64(_) => "TEXT",
DataType::Binary | DataType::LargeBinary => "BLOB",
_ => "TEXT",
}
}
/// Convert an Arrow array value at a given row index to a rusqlite Value for parameter binding.
fn array_value_to_sqlite(array: &ArrayRef, row_idx: usize) -> rusqlite::types::Value {
use crate::array_util;
use rusqlite::types::Value;
if array.is_null(row_idx) {
return Value::Null;
}
match array.data_type() {
DataType::Boolean => {
let arr = array.as_any().downcast_ref::<BooleanArray>().unwrap();
Value::Integer(arr.value(row_idx) as i64)
}
DataType::Int8 => {
let arr = array_util::as_i8(array).unwrap();
Value::Integer(arr.value(row_idx) as i64)
}
DataType::Int16 => {
let arr = array_util::as_i16(array).unwrap();
Value::Integer(arr.value(row_idx) as i64)
}
DataType::Int32 => {
let arr = array_util::as_i32(array).unwrap();
Value::Integer(arr.value(row_idx) as i64)
}
DataType::Int64 => {
let arr = array_util::as_i64(array).unwrap();
Value::Integer(arr.value(row_idx))
}
DataType::UInt8 => {
let arr = array_util::as_u8(array).unwrap();
Value::Integer(arr.value(row_idx) as i64)
}
DataType::UInt16 => {
let arr = array_util::as_u16(array).unwrap();
Value::Integer(arr.value(row_idx) as i64)
}
DataType::UInt32 => {
let arr = array_util::as_u32(array).unwrap();
Value::Integer(arr.value(row_idx) as i64)
}
DataType::UInt64 => {
let arr = array_util::as_u64(array).unwrap();
Value::Integer(arr.value(row_idx) as i64)
}
DataType::Float32 => {
let arr = array_util::as_f32(array).unwrap();
Value::Real(arr.value(row_idx) as f64)
}
DataType::Float64 => {
let arr = array_util::as_f64(array).unwrap();
Value::Real(arr.value(row_idx))
}
DataType::Utf8 => {
let arr = array_util::as_str(array).unwrap();
Value::Text(arr.value(row_idx).to_string())
}
DataType::Date32 => {
let arr = array.as_any().downcast_ref::<Date32Array>().unwrap();
let days = arr.value(row_idx);
chrono::NaiveDate::from_num_days_from_ce_opt(days + 719_163)
.and_then(|d| to_sql_value(&d))
.unwrap_or(Value::Null)
}
DataType::Timestamp(TimeUnit::Microsecond, _) => {
let arr = array
.as_any()
.downcast_ref::<TimestampMicrosecondArray>()
.unwrap();
let us = arr.value(row_idx);
chrono::DateTime::from_timestamp_micros(us)
.map(|d| d.naive_utc())
.and_then(|d| to_sql_value(&d))
.unwrap_or(Value::Null)
}
DataType::Timestamp(TimeUnit::Millisecond, _) => {
let arr = array
.as_any()
.downcast_ref::<TimestampMillisecondArray>()
.unwrap();
let ms = arr.value(row_idx);
chrono::DateTime::from_timestamp_millis(ms)
.map(|d| d.naive_utc())
.and_then(|d| to_sql_value(&d))
.unwrap_or(Value::Null)
}
DataType::Time64(TimeUnit::Nanosecond) => {
let arr = array
.as_any()
.downcast_ref::<Time64NanosecondArray>()
.unwrap();
let ns = arr.value(row_idx);
let secs = (ns / 1_000_000_000) as u32;
let nanos = (ns % 1_000_000_000) as u32;
chrono::NaiveTime::from_num_seconds_from_midnight_opt(secs, nanos)
.and_then(|t| to_sql_value(&t))
.unwrap_or(Value::Null)
}
DataType::Binary => {
let arr = array.as_any().downcast_ref::<BinaryArray>().unwrap();
Value::Blob(arr.value(row_idx).to_vec())
}
DataType::LargeBinary => {
let arr = array.as_any().downcast_ref::<LargeBinaryArray>().unwrap();
Value::Blob(arr.value(row_idx).to_vec())
}
_ => {
// Fallback: use array_util::value_to_string
Value::Text(crate::array_util::value_to_string(array, row_idx))
}
}
}
/// Use rusqlite's `ToSql` to convert a value into a `rusqlite::types::Value`.
fn to_sql_value(v: &dyn rusqlite::types::ToSql) -> Option<rusqlite::types::Value> {
use rusqlite::types::ToSqlOutput;
match v.to_sql().ok()? {
ToSqlOutput::Borrowed(vref) => Some(vref.into()),
ToSqlOutput::Owned(val) => Some(val),
_ => None,
}
}
impl Reader for SqliteReader {
fn execute_sql(&self, sql: &str) -> Result<DataFrame> {
// Handle ggsql:name namespaced identifiers (builtin datasets)
#[cfg(all(feature = "builtin-data", feature = "parquet"))]
{
let dataset_names = super::data::extract_builtin_dataset_names(sql)?;
for name in &dataset_names {
let table_name = naming::builtin_data_table(name);
if !self.table_exists(&table_name) {
let df = super::data::load_builtin_dataframe(name)?;
self.register(&table_name, df, true)?;
}
}
}
// Rewrite ggsql:name → __ggsql_data_name__ in SQL
let sql = super::data::rewrite_namespaced_sql(sql)?;
if !super::returns_rows(&sql) {
self.conn
.execute_batch(&sql)
.map_err(|e| GgsqlError::ReaderError(format!("Failed to execute SQL: {}", e)))?;
return Ok(DataFrame::empty());
}
let mut stmt = self
.conn
.prepare(&sql)
.map_err(|e| GgsqlError::ReaderError(format!("Failed to prepare SQL: {}", e)))?;
let column_count = stmt.column_count();
if column_count == 0 {
return Err(GgsqlError::ReaderError(
"Query returned no columns".to_string(),
));
}
let column_names: Vec<String> = stmt
.column_names()
.into_iter()
.map(|s| s.to_string())
.collect();
// Collect all rows, inferring types from actual values
let mut col_values: Vec<Vec<rusqlite::types::Value>> = vec![Vec::new(); column_count];
let mut rows = stmt.raw_query();
while let Some(row) = rows
.next()
.map_err(|e| GgsqlError::ReaderError(format!("Failed to fetch row: {}", e)))?
{
for (col_idx, col_vec) in col_values.iter_mut().enumerate().take(column_count) {
let value: rusqlite::types::Value = row.get(col_idx).map_err(|e| {
GgsqlError::ReaderError(format!(
"Failed to get value at column {}: {}",
col_idx, e
))
})?;
col_vec.push(value);
}
}
let named_arrays: Vec<(String, ArrayRef)> = col_values
.into_iter()
.enumerate()
.map(|(col_idx, values)| {
let name = column_names[col_idx].clone();
let array = sqlite_values_to_array(&name, values)?;
Ok((name, array))
})
.collect::<Result<Vec<_>>>()?;
DataFrame::new(named_arrays)
}
fn register(&self, name: &str, df: DataFrame, replace: bool) -> Result<()> {
super::validate_table_name(name)?;
if self.table_exists(name) {
if replace {
let sql = format!("DROP TABLE IF EXISTS {}", naming::quote_ident(name));
self.conn.execute(&sql, []).map_err(|e| {
GgsqlError::ReaderError(format!("Failed to drop table '{}': {}", name, e))
})?;
self.registered_tables.borrow_mut().remove(name);
} else {
return Err(GgsqlError::ReaderError(format!(
"Table '{}' already exists",
name
)));
}
}
// Build CREATE TABLE statement
let col_names = df.get_column_names();
let schema = df.schema();
let col_defs: Vec<String> = schema
.fields()
.iter()
.map(|field| {
let col_type = arrow_type_to_sqlite(field.data_type());
format!("{} {}", naming::quote_ident(field.name()), col_type)
})
.collect();
let create_sql = format!(
"CREATE TABLE {} ({})",
naming::quote_ident(name),
col_defs.join(", ")
);
self.conn.execute(&create_sql, []).map_err(|e| {
GgsqlError::ReaderError(format!("Failed to create table '{}': {}", name, e))
})?;
// Insert data row by row, wrapped in a transaction
if df.height() > 0 {
let placeholders: Vec<&str> = vec!["?"; df.width()];
let insert_sql = format!(
"INSERT INTO {} VALUES ({})",
naming::quote_ident(name),
placeholders.join(", ")
);
let columns = df.get_columns();
let _ = &col_names; // keep col_names alive
self.conn.execute_batch("BEGIN").map_err(|e| {
GgsqlError::ReaderError(format!("Failed to begin transaction: {}", e))
})?;
let result = (|| -> Result<()> {
let mut stmt = self.conn.prepare(&insert_sql).map_err(|e| {
GgsqlError::ReaderError(format!("Failed to prepare INSERT: {}", e))
})?;
for row_idx in 0..df.height() {
let values: Vec<rusqlite::types::Value> = columns
.iter()
.map(|col| array_value_to_sqlite(col, row_idx))
.collect();
stmt.execute(rusqlite::params_from_iter(values))
.map_err(|e| {
GgsqlError::ReaderError(format!(
"Failed to insert row {} into '{}': {}",
row_idx, name, e
))
})?;
}
Ok(())
})();
match result {
Ok(()) => {
self.conn.execute_batch("COMMIT").map_err(|e| {
GgsqlError::ReaderError(format!("Failed to commit transaction: {}", e))
})?;
}
Err(e) => {
let _ = self.conn.execute_batch("ROLLBACK");
return Err(e);
}
}
}
self.registered_tables.borrow_mut().insert(name.to_string());
Ok(())
}
fn unregister(&self, name: &str) -> Result<()> {
if !self.registered_tables.borrow().contains(name) {
return Err(GgsqlError::ReaderError(format!(
"Table '{}' was not registered via this reader",
name
)));
}
let sql = format!("DROP TABLE IF EXISTS {}", naming::quote_ident(name));
self.conn.execute(&sql, []).map_err(|e| {
GgsqlError::ReaderError(format!("Failed to unregister table '{}': {}", name, e))
})?;
self.registered_tables.borrow_mut().remove(name);
Ok(())
}
fn execute(&self, query: &str) -> Result<super::Spec> {
super::execute_with_reader(self, query)
}
fn dialect(&self) -> &dyn super::SqlDialect {
&SqliteDialect
}
fn list_catalogs(&self) -> Result<Vec<String>> {
Ok(vec![])
}
fn list_schemas(&self, _catalog: &str) -> Result<Vec<String>> {
Ok(vec![])
}
fn list_tables(&self, _catalog: &str, _schema: &str) -> Result<Vec<super::TableInfo>> {
let df = self.execute_sql(
"SELECT name, type FROM sqlite_master \
WHERE type IN ('table', 'view') ORDER BY name",
)?;
let name_col = df.column("name")?;
let type_col = df.column("type")?;
let mut results = Vec::with_capacity(df.height());
for i in 0..df.height() {
if !name_col.is_null(i) {
results.push(super::TableInfo {
name: crate::array_util::value_to_string(name_col, i),
table_type: crate::array_util::value_to_string(type_col, i),
});
}
}
Ok(results)
}
fn list_columns(
&self,
_catalog: &str,
_schema: &str,
table: &str,
) -> Result<Vec<super::ColumnInfo>> {
let df = self.execute_sql(&format!(
"SELECT name, type FROM pragma_table_info({}) ORDER BY cid",
naming::quote_literal(table)
))?;
let name_col = df.column("name")?;
let type_col = df.column("type")?;
let mut results = Vec::with_capacity(df.height());
for i in 0..df.height() {
if !name_col.is_null(i) {
results.push(super::ColumnInfo {
name: crate::array_util::value_to_string(name_col, i),
data_type: crate::array_util::value_to_string(type_col, i),
});
}
}
Ok(results)
}
}
/// Try to parse all non-null TEXT values as ISO-8601 dates (YYYY-MM-DD).
/// Returns a Date32 array if all non-null values parse, None otherwise.
fn try_parse_as_date(values: &[rusqlite::types::Value]) -> Option<ArrayRef> {
use rusqlite::types::{FromSql, Value, ValueRef};
// Days between 0001-01-01 (CE day 1) and 1970-01-01 (Unix epoch)
const EPOCH_DAYS_FROM_CE: i32 = 719_163;
let mut parsed: Vec<Option<i32>> = Vec::with_capacity(values.len());
for v in values {
match v {
Value::Null => parsed.push(None),
Value::Text(s) => {
let vref = ValueRef::Text(s.as_bytes());
let date: chrono::NaiveDate = FromSql::column_result(vref).ok()?;
parsed.push(Some(date.num_days_from_ce() - EPOCH_DAYS_FROM_CE));
}
_ => return None,
}
}
Some(Arc::new(Date32Array::from(parsed)) as ArrayRef)
}
/// Try to parse all non-null TEXT values as ISO-8601 datetimes.
/// Supports both "T" and space separators (e.g. "2024-01-15T10:30:00" or "2024-01-15 10:30:00").
/// Returns a TimestampMillisecond array if all non-null values parse, None otherwise.
fn try_parse_as_datetime(values: &[rusqlite::types::Value]) -> Option<ArrayRef> {
use rusqlite::types::{FromSql, Value, ValueRef};
let mut parsed: Vec<Option<i64>> = Vec::with_capacity(values.len());
for v in values {
match v {
Value::Null => parsed.push(None),
Value::Text(s) => {
// Must contain a time separator to distinguish from plain dates
if !s.contains('T') && !s.contains(' ') {
return None;
}
let vref = ValueRef::Text(s.as_bytes());
let dt: chrono::NaiveDateTime = FromSql::column_result(vref).ok()?;
parsed.push(Some(dt.and_utc().timestamp_millis()));
}
_ => return None,
}
}
Some(Arc::new(TimestampMillisecondArray::from(parsed)) as ArrayRef)
}
/// Infer the best Arrow type from a column of SQLite values and build an ArrayRef.
///
/// SQLite uses dynamic typing, so we infer the column type from all values:
/// - All Integer -> Int64
/// - All Integer/Real -> Float64
/// - All Text -> String (with temporal detection)
/// - Mixed -> String fallback
fn sqlite_values_to_array(name: &str, values: Vec<rusqlite::types::Value>) -> Result<ArrayRef> {
use rusqlite::types::Value;
let _ = name; // name is unused now but kept for consistency
if values.is_empty() {
// Default to String for empty columns
return Ok(Arc::new(StringArray::from(Vec::<Option<&str>>::new())) as ArrayRef);
}
// Determine the dominant type
let mut has_int = false;
let mut has_real = false;
let mut has_text = false;
let mut has_blob = false;
for v in &values {
match v {
Value::Null => {}
Value::Integer(_) => has_int = true,
Value::Real(_) => has_real = true,
Value::Text(_) => has_text = true,
Value::Blob(_) => has_blob = true,
}
}
// If we have text, try temporal detection before falling back to String
if has_text && !has_blob {
if let Some(array) = try_parse_as_date(&values) {
return Ok(array);
}
if let Some(array) = try_parse_as_datetime(&values) {
return Ok(array);
}
}
// A pure BLOB column (e.g. WKB geometry) maps to Arrow Binary so geometry
// auto-detection and spatial layers receive raw bytes, not a debug string.
if has_blob && !has_text && !has_int && !has_real {
let vals: Vec<Option<Vec<u8>>> = values
.into_iter()
.map(|v| match v {
Value::Blob(b) => Some(b),
_ => None,
})
.collect();
return Ok(Arc::new(BinaryArray::from_iter(vals.iter().map(|o| o.as_deref()))) as ArrayRef);
}
if has_text || has_blob {
let vals: Vec<Option<String>> = values
.into_iter()
.map(|v| match v {
Value::Null => None,
Value::Integer(i) => Some(i.to_string()),
Value::Real(f) => Some(f.to_string()),
Value::Text(s) => Some(s),
Value::Blob(b) => Some(format!("{:?}", b)),
})
.collect();
let refs: Vec<Option<&str>> = vals.iter().map(|s| s.as_deref()).collect();
return Ok(Arc::new(StringArray::from(refs)) as ArrayRef);
}
// If we have any reals, use f64
if has_real {
let vals: Vec<Option<f64>> = values
.into_iter()
.map(|v| match v {
Value::Null => None,
Value::Integer(i) => Some(i as f64),
Value::Real(f) => Some(f),
_ => None,
})
.collect();
return Ok(Arc::new(Float64Array::from(vals)) as ArrayRef);
}
// Pure integers
if has_int {
let vals: Vec<Option<i64>> = values
.into_iter()
.map(|v| match v {
Value::Null => None,
Value::Integer(i) => Some(i),
_ => None,
})
.collect();
return Ok(Arc::new(Int64Array::from(vals)) as ArrayRef);
}
// All nulls — default to String
let vals: Vec<Option<&str>> = values.iter().map(|_| None).collect();
Ok(Arc::new(StringArray::from(vals)) as ArrayRef)
}
#[cfg(test)]
mod tests {
use super::*;
use crate::array_util::as_i64;
use crate::df;
#[test]
fn test_create_in_memory() {
let reader = SqliteReader::new();
assert!(reader.is_ok());
}
#[test]
fn test_simple_query() {
let reader = SqliteReader::new().unwrap();
let df = reader.execute_sql("SELECT 1 as x, 2 as y").unwrap();
assert_eq!(df.shape(), (1, 2));
assert_eq!(
df.get_column_names(),
vec!["x".to_string(), "y".to_string()]
);
}
#[test]
fn test_subquery_preserves_integer_types() {
let reader = SqliteReader::new().unwrap();
let df = reader
.execute_sql("SELECT x, y FROM (SELECT 1 AS x, 1 AS y)")
.unwrap();
assert_eq!(df.shape(), (1, 2));
assert_eq!(df.column_dtype("x").unwrap(), DataType::Int64);
assert_eq!(df.column_dtype("y").unwrap(), DataType::Int64);
}
#[test]
fn test_subquery_vegalite_quantitative() {
use crate::writer::{VegaLiteWriter, Writer};
let reader = SqliteReader::new().unwrap();
let spec = reader
.execute("SELECT x, y FROM (SELECT 1 AS x, 1 AS y) VISUALISE x AS x, y AS y DRAW point")
.unwrap();
let writer = VegaLiteWriter::new();
let json = writer.render(&spec).unwrap();
// x and y should be quantitative, not nominal
assert!(
json.contains("\"quantitative\""),
"Expected quantitative type in output: {}",
json
);
assert!(
!json.contains("\"nominal\""),
"Did not expect nominal type in output: {}",
json
);
}
#[test]
fn test_table_creation_and_query() {
let reader = SqliteReader::new().unwrap();
reader
.connection()
.execute("CREATE TABLE test(x INTEGER, y INTEGER)", [])
.unwrap();
reader
.connection()
.execute("INSERT INTO test VALUES (1, 2), (3, 4)", [])
.unwrap();
let df = reader.execute_sql("SELECT * FROM test").unwrap();
assert_eq!(df.shape(), (2, 2));
assert_eq!(
df.get_column_names(),
vec!["x".to_string(), "y".to_string()]
);
}
#[test]
fn test_invalid_sql() {
let reader = SqliteReader::new().unwrap();
let result = reader.execute_sql("INVALID SQL SYNTAX");
assert!(result.is_err());
}
#[test]
fn test_register_and_query() {
let reader = SqliteReader::new().unwrap();
let df = df! {
"x" => vec![1i32, 2, 3],
"y" => vec![10i32, 20, 30],
}
.unwrap();
reader.register("my_table", df, false).unwrap();
let result = reader
.execute_sql("SELECT * FROM my_table ORDER BY x")
.unwrap();
assert_eq!(result.shape(), (3, 2));
assert_eq!(
result.get_column_names(),
vec!["x".to_string(), "y".to_string()]
);
}
#[test]
fn test_register_duplicate_name_errors() {
let reader = SqliteReader::new().unwrap();
let df1 = df! { "a" => vec![1i32] }.unwrap();
let df2 = df! { "b" => vec![2i32] }.unwrap();
reader.register("dup_table", df1, false).unwrap();
let result = reader.register("dup_table", df2, false);
assert!(result.is_err());
let err = result.unwrap_err().to_string();
assert!(err.contains("already exists"));
}
#[test]
fn test_register_invalid_table_names() {
let reader = SqliteReader::new().unwrap();
let df = df! { "a" => vec![1i32] }.unwrap();
let result = reader.register("", df.clone(), false);
assert!(result.is_err());
assert!(result.unwrap_err().to_string().contains("cannot be empty"));
// Name with double quote should succeed (quote_ident escapes it)
let result = reader.register("bad\"name", df.clone(), false);
assert!(result.is_ok());
reader.unregister("bad\"name").unwrap();
let result = reader.register("bad\0name", df.clone(), false);
assert!(result.is_err());
assert!(result
.unwrap_err()
.to_string()
.contains("invalid character"));
}
#[test]
fn test_register_empty_dataframe() {
let reader = SqliteReader::new().unwrap();
// Create an empty DataFrame with schema by slicing a 1-row df to 0 rows
let df = df! {
"x" => vec![0i32],
"y" => vec!["placeholder"],
}
.unwrap()
.slice(0, 0);
reader.register("empty_table", df, false).unwrap();
let result = reader.execute_sql("SELECT * FROM empty_table").unwrap();
assert_eq!(result.shape(), (0, 2));
assert_eq!(
result.get_column_names(),
vec!["x".to_string(), "y".to_string()]
);
}
#[test]
fn test_unregister() {
let reader = SqliteReader::new().unwrap();
let df = df! { "x" => vec![1i32, 2, 3] }.unwrap();
reader.register("test_data", df, false).unwrap();
let result = reader.execute_sql("SELECT * FROM test_data").unwrap();
assert_eq!(result.height(), 3);
reader.unregister("test_data").unwrap();
let result = reader.execute_sql("SELECT * FROM test_data");
assert!(result.is_err());
}
#[test]
fn test_unregister_not_registered() {
let reader = SqliteReader::new().unwrap();
reader
.connection()
.execute("CREATE TABLE user_table (x INTEGER)", [])
.unwrap();
let result = reader.unregister("user_table");
assert!(result.is_err());
let err = result.unwrap_err().to_string();
assert!(err.contains("was not registered via this reader"));
}
#[test]
fn test_reregister_after_unregister() {
let reader = SqliteReader::new().unwrap();
let df = df! { "x" => vec![1i32, 2, 3] }.unwrap();
reader.register("data", df.clone(), false).unwrap();
reader.unregister("data").unwrap();
reader.register("data", df, false).unwrap();
let result = reader.execute_sql("SELECT * FROM data").unwrap();
assert_eq!(result.height(), 3);
}
#[test]
fn test_register_large_dataframe() {
let reader = SqliteReader::new().unwrap();
let n = 3000;
let ids: Vec<i32> = (0..n).collect();
let values: Vec<f64> = (0..n).map(|i| i as f64 * 1.5).collect();
let names: Vec<String> = (0..n).map(|i| format!("item_{}", i)).collect();
let df = df! {
"id" => ids,
"value" => values,
"name" => names,
}
.unwrap();